Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unvendor distutils.version #3988

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Unvendor distutils.version #3988

merged 2 commits into from
Jan 8, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Undo #3984. This is ok since we drop support for Ansible 2.9 and ansible-base 2.10 in the next major release.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/version.py
plugins/module_utils/_version.py

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Jan 5, 2022
@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 5, 2022
@rockaut rockaut mentioned this pull request Jan 7, 2022
Merged
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 8, 2022
@felixfontein felixfontein merged commit 29e8f5f into ansible-collections:main Jan 8, 2022
@felixfontein felixfontein deleted the distutils-unvendor branch January 8, 2022 20:45
@felixfontein
Copy link
Collaborator Author

@tadeboro thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeboro tadeboro tadeboro approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @tadeboro @ansibullbot