Use vendored copy of distutils.version #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
briantist
approved these changes
Jan 5, 2022
|
I did test it in community.docker with old Ansible versions; here it was only tested with the latest stable-x branches. |
This was referenced Jan 5, 2022
Merged
Merged
Merged
Prepare for distutils.version being removed in Python 3.12
ansible-collections/community.vmware#1165
Merged
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3986 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit cf7a333)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #3987 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit cf7a333)
|
@briantist thanks for reviewing this! |
felixfontein
added a commit
that referenced
this pull request
Jan 5, 2022
felixfontein
added a commit
that referenced
this pull request
Jan 5, 2022
felixfontein
commented
Jan 6, 2022
| except ImportError as exc: | ||
| msg = 'To use this plugin or module with ansible-core < 2.11, you need to use Python < 3.12 with distutils.version present' | ||
| raise_from(ImportError(msg), exc) | ||
| # Once we drop support for Ansible 2.9 and ansible-base 2.10, we can |
There was a problem hiding this comment.
This line should have been
# Once we drop support for Ansible 2.9 and ansible-base 2.10, we can
# Once we drop support for Ansible 2.9, ansible-base 2.10, and ansible-core 2.11, we canFixing in follow-up PR #3993.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #3979. This fixes the issue the current fix (#3936) had for Ansible 2.9 before 2.9.20, and ansible-base 2.10 before 2.10.8.
ISSUE TYPE
COMPONENT NAME
plugins/module_util/version.py