ec2_asg: Add functionality to detach specified instances from ASG #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
Build succeeded.
|
alinabuzachis
requested changes
Feb 14, 2022
There was a problem hiding this comment.
@mandar242 Thank you for working on this. You should add some integration tests for these features and a changelog fragment.
mandar242
force-pushed
the
649_ec2_asg_detach_instance
branch
from
18ceaaf
to
96b9bbc
Compare
|
Build succeeded.
|
There was a problem hiding this comment.
@mandar242 You also would need a changelog fragment and integration tests for these options.
mandar242
force-pushed
the
649_ec2_asg_detach_instance
branch
from
96b9bbc
to
459af5e
Compare
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
mandar242
changed the title
jillr
reviewed
Feb 22, 2022
There was a problem hiding this comment.
Two minor nits on some error messages, otherwise the code looks good - thanks @mandar242
|
recheck |
|
afaict the timeout is just because we have to wait for instances on several tasks and the API was being slow when the tests ran. |
|
recheck |
jatorcasso
approved these changes
Feb 25, 2022
| def detach(connection): | ||
| group_name = module.params.get('name') | ||
| detach_instances = module.params.get('detach_instances') | ||
| as_group = describe_autoscaling_groups(connection, group_name)[0] |
There was a problem hiding this comment.
is there a case where multiple autoscaling groups are returned here?
There was a problem hiding this comment.
I think as we are passing only single group name, we will only single auto scaling group's info.
There was a problem hiding this comment.
just checking! Wasnt sure if there were cases where multiple groups had the same name
There was a problem hiding this comment.
ASG name is unique within a region and account. Since we can only act on one region and account at a time, this works well.
jillr
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
The code lgtm, thanks very much @mandar242! I'll hold off on tagging this to merge over the weekend in case @alinabuzachis would like to update her review but with CI passing I think this is ready.
alinabuzachis
approved these changes
Feb 26, 2022
1 task
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Mar 11, 2022
…sible-collections#933) ec2_asg: Add functionality to detach specified instances from ASG SUMMARY Adds feature to detach specified instances from a AutoScalingGroup rather than terminating them directly. Detached instances are not terminated and can be managed independently. Implements ansible-collections#649 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_asg ADDITIONAL INFORMATION Makes use of https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.detach_instances Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds feature to detach specified instances from a AutoScalingGroup rather than terminating them directly.
Detached instances are not terminated and can be managed independently.
Implements #649
ISSUE TYPE
COMPONENT NAME
ec2_asg
ADDITIONAL INFORMATION
Makes use of
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.detach_instances