ec2_placement_group: Add partition strategy and partition count #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build succeeded.
|
|
recheck |
alinabuzachis
requested changes
Jan 17, 2022
There was a problem hiding this comment.
@mandar242 Thank you for working on this. Could you also add some integration tests for this parameter? Thanks.
This comment has been minimized.
This comment has been minimized.
alinabuzachis
requested changes
Jan 25, 2022
There was a problem hiding this comment.
@mandar242 This looks great but we'll need some integration tests for this parameter.
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
mandar242
force-pushed
the
808_ec2_placement_group_partition
branch
from
0342db6
to
1bb84e1
Compare
ansibullbot
added
community_review
feature
This comment has been minimized.
This comment has been minimized.
|
Build succeeded.
|
alinabuzachis
requested changes
Feb 2, 2022
tests/integration/targets/ec2_placement_group/defaults/main.yml
Outdated
Show resolved
Hide resolved
| - pg_2_create is changed | ||
| - pg_2_create.placement_group.name == '{{ resource_prefix }}-pg2' | ||
| - pg_2_create.placement_group.state == "available" | ||
| - '"ec2:CreatePlacementGroup" in pg_2_create.resource_actions' |
There was a problem hiding this comment.
I n my opinion, you can remove all the statements similar to this - '"ec2:CreatePlacementGroup" in pg_2_create.resource_actions'
There was a problem hiding this comment.
@alinabuzachis I think it can be a decent additional check to make sure resource action took place. But if it could cause any unnecessary issues in future that I might be missing, I'd be fine with removing them as well.
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded.
|
alinabuzachis
approved these changes
Feb 4, 2022
| - pg_2_create is changed | ||
| - pg_2_create.placement_group.name == '{{ resource_prefix }}-pg2' | ||
| - pg_2_create.placement_group.state == "available" | ||
| - '"ec2:CreatePlacementGroup" in pg_2_create.resource_actions' |
marknet15
approved these changes
Feb 4, 2022
alinabuzachis
added
backport-3
|
Build succeeded (gate pipeline).
|
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #928 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
ec2_placement_group: Add partition strategy and partition count SUMMARY Add partition as a strategy and an option, partition_count to choose the actual number of partitions for the community.aws.ec2_placement_group module. Fixes #808 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_placement_group ADDITIONAL INFO Tested locally with - name: Create a partition placement group with partition count 4. ec2_placement_group: name: my-cluster state: present strategy: partition partition_count: 4 Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Woolley <mw@marknet15.com> (cherry picked from commit 716ae77)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
#928) [PR #872/716ae77f backport][stable-3] ec2_placement_group: Add partition strategy and partition count This is a backport of PR #872 as merged into main (716ae77). SUMMARY Add partition as a strategy and an option, partition_count to choose the actual number of partitions for the community.aws.ec2_placement_group module. Fixes #808 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_placement_group ADDITIONAL INFO Tested locally with - name: Create a partition placement group with partition count 4. ec2_placement_group: name: my-cluster state: present strategy: partition partition_count: 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
partitionas a strategy and an option,partition_countto choose the actual number of partitions for the community.aws.ec2_placement_group module.Fixes #808
ISSUE TYPE
COMPONENT NAME
ec2_placement_group
ADDITIONAL INFO
Tested locally with