iam_role_info jittered backoff #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
tremble
requested changes
Oct 8, 2021
plugins/modules/iam_role.py
Outdated
Comment on lines
217
to
219
| @AWSRetry.jittered_backoff() | ||
| def _list_policies(connection): | ||
| paginator = connection.get_paginator('list_policies') |
There was a problem hiding this comment.
Unfortunately the decorator needs to stay outside the function here. (but switching to jittered_backoff is generally a good idea)
The retry decorator we use isn't clever enough to delve into the innards or build_full_results and do what you'd expect with aws_retry. (I did look into it it's a rather complex web of calls deep in boto3
tremble
approved these changes
Oct 9, 2021
![ansible-zuul[bot]](https://github.com/avatars/in/27800?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sometimes some rate limiting exceptions on the lookups still cause failures, I've switched the
iam_role_infotojittered_backoffin a similar vein to:#324
ISSUE TYPE
COMPONENT NAME
iam_role_info