Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs_taskdefinition - add placement_constraints option #741

Merged
merged 3 commits into from
Oct 15, 2021
Merged

ecs_taskdefinition - add placement_constraints option #741

merged 3 commits into from
Oct 15, 2021

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Oct 1, 2021 •
edited by goneri
Loading

Depends-On: ansible/ansible-zuul-jobs#1179

SUMMARY

Add placement_constraints option.

Fixes: #714

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_taskdefinition

@alinabuzachis alinabuzachis force-pushed the task_definition/placement-option branch 3 times, most recently from 9f2e727 to acacc03 Compare October 1, 2021 15:24
@alinabuzachis
ecs_taskdefinition - add placement_constraints option
4b9a83c 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the task_definition/placement-option branch from acacc03 to 4b9a83c Compare October 1, 2021 15:25
@ansibullbot
Copy link

cc @Java1Guy @jillr @markuman @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 1, 2021
tremble
tremble requested changes Oct 2, 2021
View reviewed changes
plugins/modules/ecs_taskdefinition.py Outdated Show resolved Hide resolved
@alinabuzachis
Address reviewer's comments
a578f72 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the task_definition/placement-option branch 3 times, most recently from a720c7f to 9312cf7 Compare October 8, 2021 12:25
@alinabuzachis alinabuzachis force-pushed the task_definition/placement-option branch from 9312cf7 to b89d24a Compare October 8, 2021 12:27
@goneri
Copy link
Member

goneri commented Oct 13, 2021

recheck

@tremble tremble added the gate label Oct 14, 2021
@tremble tremble added gate and removed gate labels Oct 15, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 9beae2c into ansible-collections:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@ansible-zuul Ansible Zuul Ansible Zuul approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support of placement_constraints in community.aws.ecs_taskdefinition module
4 participants
@alinabuzachis @ansibullbot @goneri @tremble