Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ec2_vpc_endpoint_info AWS retries #537

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Update ec2_vpc_endpoint_info AWS retries #537

merged 2 commits into from
Apr 12, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 10, 2021

SUMMARY

We're still seeing some failures during Integration tests because we caught ClientError before the decorator could retry it.

https://app.shippable.com/github/ansible-collections/community.aws/runs/2267/24/tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_endpoint_info

ADDITIONAL INFORMATION
  File "/tmp/ansible_ec2_vpc_endpoint_info_payload_fXIuP1/ansible_ec2_vpc_endpoint_info_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_endpoint_info.py", line 152, in get_endpoints
  File "/usr/local/lib/python2.7/dist-packages/botocore/paginate.py", line 449, in build_full_result
    for response in self:
  File "/usr/local/lib/python2.7/dist-packages/botocore/paginate.py", line 255, in __iter__
    response = self._make_request(current_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/paginate.py", line 332, in _make_request
    return self._method(**current_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 676, in _make_api_call
    raise error_class(parsed_response, operation_name)
ClientError: An error occurred (RequestLimitExceeded) when calling the DescribeVpcEndpoints operation (reached max retries: 4): Request limit exceeded.

@ansibullbot
Copy link

cc @Etherdaemon @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) traceback labels Apr 10, 2021
@tremble tremble force-pushed the ec2_vpc_endpoint_info/retries branch from ad17001 to 8acde77 Compare April 10, 2021 10:53
@ansibullbot ansibullbot added community_review integration tests/integration tests tests and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR owner_pr PR created by owner/maintainer labels Apr 10, 2021
@tremble
Copy link
Contributor Author

tremble commented Apr 10, 2021

recheck

@tremble
Copy link
Contributor Author

tremble commented Apr 11, 2021

We were also seeing test failures because the tag search assumed the first result would be the result from the current test, but with tests running in parallel we were seeing multiple matches. Test updated to use a unique tag

alinabuzachis
alinabuzachis approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. retry_decorator here https://github.com/ansible-collections/community.aws/pull/537/files#diff-2fcea7c1c0af69ed5357b4f2a5d4a3bd9396ee92182f416075504e5695a0bb67L175?

@tremble
Copy link
Contributor Author

tremble commented Apr 12, 2021

LGTM. retry_decorator here https://github.com/ansible-collections/community.aws/pull/537/files#diff-2fcea7c1c0af69ed5357b4f2a5d4a3bd9396ee92182f416075504e5695a0bb67L175?

Because all of the ec2 calls are paginated retry_decorator doesn't help, if there were any not-paginated calls I'd have added retry_decorator.

@tremble tremble added the gate label Apr 12, 2021
@ansible-zuul ansible-zuul bot merged commit 893d08c into ansible-collections:main Apr 12, 2021
@tremble tremble deleted the ec2_vpc_endpoint_info/retries branch June 29, 2021 12:58
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#537 from tremble/ec2…
edeed33 
…_vpc_endpoint_info/retries

Update ec2_vpc_endpoint_info AWS retries

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@893d08c
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#537 from tremble/ec2_vpc_endpo…
8612c78 
…int_info/retries

Update ec2_vpc_endpoint_info AWS retries

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#537 from tremble/ec2_vpc_endpo…
5822750 
…int_info/retries

Update ec2_vpc_endpoint_info AWS retries

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests traceback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @alinabuzachis