Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_instance - test fixups #515

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 31, 2021

SUMMARY

The rds_instance tests are currenlty broken

  • rds_snapshot is missing from meta/runtime.yml
  • test_read_replica.yml syntax mistake
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance
rds_snapshot

ADDITIONAL INFORMATION

@tremble
Copy link
Contributor Author

tremble commented Mar 31, 2021

@alinabuzachis since you're working on #500 could you take a look at this PR I tried running the tests (without your changes) locally and had various failures

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) tests tests labels Mar 31, 2021
@alinabuzachis
Copy link
Contributor

@alinabuzachis since you're working on #500 could you take a look at this PR I tried running the tests (without your changes) locally and had various failures

@tremble Yes, sure! Thank you.

Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 1, 2021
@tremble tremble merged commit 1722d02 into ansible-collections:main Apr 6, 2021
@tremble tremble deleted the rds_instance/test-fixups branch June 29, 2021 12:58
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* rds_instance - fix test syntax - test_read_replica.yml
* Note that rds_instance tests are slow
* add rds_snapshot to aws group
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* rds_instance - fix test syntax - test_read_replica.yml
* Note that rds_instance tests are slow
* add rds_snapshot to aws group
* changelog
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
* rds_instance - fix test syntax - test_read_replica.yml
* Note that rds_instance tests are slow
* add rds_snapshot to aws group
* changelog
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
Doc fix ec2_vol_info

SUMMARY

attachment_set has always be returned as a list of dictionaries, but the module documented it as a dictionary instead. Let's fix this documentation mismatch.
"attachment_set": [{
            "attach_time": "2015-10-23T00:22:29.000Z",
            "deleteOnTermination": "false",
            "device": "/dev/sdf",
            "instance_id": "i-8356263c",
            "status": "attached"
        }]

Fixes: ansible-collections#515

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ec2_vol_info

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
* rds_instance - fix test syntax - test_read_replica.yml
* Note that rds_instance tests are slow
* add rds_snapshot to aws group
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@1722d02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants