Avoid per-test virtual environments where possible #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jillr @matt-telstra @s-hertel @wimnat @yaakov-github |
ansibullbot
added
community_review
integration
tremble
force-pushed
the
cleanup/botocore_versions
branch
2 times, most recently
from
e2d979e
to
9865d06
Compare
… to run the prep work twice
tremble
force-pushed
the
cleanup/botocore_versions
branch
from
9865d06
to
035796f
Compare
ansibullbot
added
needs_revision
ansibullbot
added
community_review
and removed
needs_revision
goneri
approved these changes
Mar 10, 2021
jillr
approved these changes
Mar 10, 2021
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
…ns#467) * Move ec2_launch_template to standard role-type test * Run elb_application_lb in our standard environment * Move elb_target_info to the standard role structure * add remote_tmp_dir dependency to ec2_launch_template * move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice * Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us * Ensure ALBs are deleted if "failed" tests created something
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ns#467) * Move ec2_launch_template to standard role-type test * Run elb_application_lb in our standard environment * Move elb_target_info to the standard role structure * add remote_tmp_dir dependency to ec2_launch_template * move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice * Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us * Ensure ALBs are deleted if "failed" tests created something
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ns#467) * Move ec2_launch_template to standard role-type test * Run elb_application_lb in our standard environment * Move elb_target_info to the standard role structure * add remote_tmp_dir dependency to ec2_launch_template * move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice * Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us * Ensure ALBs are deleted if "failed" tests created something
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…ns#467) * Move ec2_launch_template to standard role-type test * Run elb_application_lb in our standard environment * Move elb_target_info to the standard role structure * add remote_tmp_dir dependency to ec2_launch_template * move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice * Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us * Ensure ALBs are deleted if "failed" tests created something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move the primary tests for various modules over to using the standard virtual environment:
ISSUE TYPE
COMPONENT NAME
ec2_launch_template
elb_application_lb
elb_target_info
ADDITIONAL INFORMATION
#442 exposed that some test suites were running in their own custom virtual environment when they didn't need to. Move the non-version-dependent tests back to our standard environment