improve ec2_vpc_nat_gateway stability #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
Looking at the calls invoked I suspect that the 'search' for gateways is flakey: Note: ec2:CreateNatGateway was invoked! |
tremble
force-pushed
the
stability/ec2_vpc_nat_gateway
branch
from
b98e4d9
to
d34d850
Compare
tremble
force-pushed
the
stability/ec2_vpc_nat_gateway
branch
from
2593277
to
42c70dc
Compare
ansibullbot
added
integration
…ems to have fixed things
tremble
force-pushed
the
stability/ec2_vpc_nat_gateway
branch
from
42c70dc
to
e19eca6
Compare
tremble
changed the title
alinabuzachis
approved these changes
Feb 23, 2021
|
Reran the tests again for good measure, still coming back all green! I have a +1 from @alinabuzachis so I'll get this merged and so the other PRs can be rebased. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
) * attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@38be7f9
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
ec2_key : Fix tests SUMMARY The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt "stderr": "/bin/sh: line 1: openssl: command not found" Depends-on: ansible-collections#460 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@38be7f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We're seeing a lot of failures with ec2_vpc_nat_gateway
ISSUE TYPE
COMPONENT NAME
ec2_vpc_nat_gateway
ADDITIONAL INFORMATION