Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state=get on route53 module (Issue #423) #424

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix state=get on route53 module (Issue #423) #424

merged 2 commits into from
Mar 11, 2021

Conversation

pjrm
Copy link
Contributor

@pjrm pjrm commented Feb 18, 2021 •
edited
Loading

#423 This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

Also, I added a test to cover this case.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • route53

@pjrm pjrm mentioned this pull request Feb 18, 2021
Closed
@ansibullbot
Copy link

cc @jillr @jimbydamonk @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review has_issue integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Feb 18, 2021
@pjrm
Fix state=get on route53 module
7acf822 
This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.
@tremble tremble linked an issue Feb 27, 2021 that may be closed by this pull request
Route53 module fails with KeyError: DelegationSet #423
Closed
tremble
tremble approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak to the changelog format, but otherwise looks good.

changelogs/fragments/406-route53-state-get.yml Outdated Show resolved Hide resolved
@tremble
Copy link
Contributor

tremble commented Mar 11, 2021

Tests are passing. Thought I merged this already :)

@tremble tremble merged commit 331ada1 into ansible-collections:main Mar 11, 2021
@tremble
Copy link
Contributor

tremble commented Mar 11, 2021

@pjrm Thanks for your work on this issue. Sorry it's taken a while to get this merged.

danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
@pjrm @tremble @danquixote
Fix state=get on route53 module (Issue ansible-collections#423) (ansi…
7673e1d 
…ble-collections#424)

* Fix state=get on route53 module

This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

* Update changelogs/fragments/406-route53-state-get.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@pjrm @tremble
Fix state=get on route53 module (Issue ansible-collections#423) (ansi…
638b22f 
…ble-collections#424)

* Fix state=get on route53 module

This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

* Update changelogs/fragments/406-route53-state-get.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@pjrm @tremble
Fix state=get on route53 module (Issue ansible-collections#423) (ansi…
f39d1ec 
…ble-collections#424)

* Fix state=get on route53 module

This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

* Update changelogs/fragments/406-route53-state-get.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@pjrm @tremble @danielcotton
Fix state=get on route53 module (Issue ansible-collections#423) (ansi…
c3d0f01 
…ble-collections#424)

* Fix state=get on route53 module

This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

* Update changelogs/fragments/406-route53-state-get.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Formally start the ec2 deprecation process (ansible-collections#424)
af03411 
Formally start the ec2 deprecation process

SUMMARY
The ec2 module is based upon the deprecated boto (not boto3/botocore) SDK and most functionality has been replaced by the ec2_instance module.
Formally start the deprecation process and give it 2 major releases.
For practical purposes the ec2 module has a number of limitations (things like not supporting all regions) and we're still getting bugs filed against it for quirky behaviour that's fixed in ec2_instance.  By formally starting the deprecation process we can move most folks over to ec2_instance where possible and avoid trying to support 2 modules at the same time.
The major missing feature with the ec2_instance module is spot instances.  Support for spot instances is underway in ansible-collections#407
Should spot instance support not be available by 3.0.0 we can always extend the deprecation period.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@pjrm @tremble @goneri
Fix state=get on route53 module (Issue ansible-collections#423) (ansi…
e1829f5 
…ble-collections#424)

* Fix state=get on route53 module

This bug was introduced when refactoring from boto to boto3 library. This happens because the method "get_hosted_zone" only returns the DelegationSet when the DNS zone is external. Therefore this breaks when trying to get internal records.

The solution is to search for getting DNS records of type ''NS'' with the same name as the hosted zone.

* Update changelogs/fragments/406-route53-state-get.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@331ada1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review has_issue integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route53 module fails with KeyError: DelegationSet
4 participants
@pjrm @ansibullbot @tremble @markuman