Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk import cleanup #360

Merged
merged 5 commits into from
Jan 16, 2021
Merged

Bulk import cleanup #360

merged 5 commits into from
Jan 16, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 15, 2021 •
edited
Loading

SUMMARY

Various modules were importing things and not using them. Clean this up.

  • Move everything to sorted imports (one import per line)
  • Pull camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
  • Remove unused imports
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_config_aggregation_authorization.py
plugins/modules/aws_config_delivery_channel.py
plugins/modules/aws_config_recorder.py
plugins/modules/aws_config_rule.py
plugins/modules/cloudformation_stack_set.py
plugins/modules/cloudfront_origin_access_identity.py
plugins/modules/cloudwatchlogs_log_group_metric_filter.py
plugins/modules/dynamodb_ttl.py
plugins/modules/ec2_ami_copy.py
plugins/modules/ec2_customer_gateway.py
plugins/modules/ec2_elb.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_instance_info.py
plugins/modules/ec2_lc_info.py
plugins/modules/ec2_snapshot_copy.py
plugins/modules/ec2_vpc_endpoint_info.py
plugins/modules/ec2_vpc_vgw.py
plugins/modules/ecs_attribute.py
plugins/modules/ecs_cluster.py
plugins/modules/ecs_taskdefinition.py
plugins/modules/elasticache_parameter_group.py
plugins/modules/elb_application_lb_info.py
plugins/modules/elb_instance.py
plugins/modules/elb_target.py
plugins/modules/elb_target_group_info.py
plugins/modules/iam_mfa_device_info.py
plugins/modules/iam_server_certificate_info.py
plugins/modules/iam_user_info.py
plugins/modules/lambda_event.py
plugins/modules/route53_health_check.py
plugins/modules/route53_info.py
plugins/modules/s3_metrics_configuration.py
plugins/modules/s3_website.py
plugins/modules/sns.py
plugins/modules/sts_session_token.py

ADDITIONAL INFORMATION

felixfontein
felixfontein reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should this have a changelog?

@ansibullbot
Copy link

cc @Akasurde @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @MichaelBaydoun @Shaps @amir343 @anryko @defunctio @flowerysong @jarv @jillr @linuxdynasty @markuman @michaeljs1990 @mjschultz @naslanidis @pjodouin @psykotox @pwnall @s-hertel @slapula @vorotech @wilvk @wimnat @zimbatm
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 15, 2021
@tremble
Copy link
Contributor Author

tremble commented Jan 16, 2021

Approvals in place from both @jillr and @felixfontein tests passing. Merging

@tremble tremble merged commit 130cf3c into ansible-collections:main Jan 16, 2021
@tremble tremble deleted the cleanup/imports branch February 11, 2021 09:12
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@tremble
[promoted]Bulk import cleanup (ansible-collections#360)
204453f 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
Bulk import cleanup (ansible-collections#360)
6352a63 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
Bulk import cleanup (ansible-collections#360)
07dc9ae 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@tremble @danielcotton
Bulk import cleanup (ansible-collections#360)
25a08b1 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@jillr
Add netcommon to test requirements for ipv6 filter (ansible-collectio…
4342fcc 
…ns#360)

Add netcommon to test requirements for ipv6 filter

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble @jillr
Bulk import cleanup (ansible-collections#360)
3f47876 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble @alinabuzachis
Bulk import cleanup (ansible-collections#360)
d91e690 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @alinabuzachis
Bulk import cleanup (ansible-collections#360)
ae28271 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Bulk import cleanup (ansible-collections#360)
8b9727a 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Bulk import cleanup (ansible-collections#360)
02c37c0 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Bulk import cleanup (ansible-collections#360)
c6a4c60 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @alinabuzachis
Bulk import cleanup (ansible-collections#360)
05858c2 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @alinabuzachis
Bulk import cleanup (ansible-collections#360)
25d3a35 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @github-actions
Bulk import cleanup (ansible-collections#360)
76e3255 
* Split imports and reorder
* Import camel_dict_to_snake_dict and snake_dict_to_camel_dict direct from ansible.module_utils.common.dict_transformations
* Remove unused imports
* Route53 Info was migrated to Boto3 drop the HAS_BOTO check and import
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@130cf3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

@felixfontein felixfontein felixfontein approved these changes

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @ansibullbot @jillr @felixfontein