Launch Template cleanup retries and add tests into CI #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
tests/launch_template
branch
from
c35954a
to
de20395
Compare
tremble
force-pushed
the
tests/launch_template
branch
from
de20395
to
1cd500e
Compare
tremble
changed the title
jillr
approved these changes
Dec 15, 2020
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…tions#326) * Mark ec2_launch_template tests as supported * Update launch template test to use permitted harmless managed policy * Make sure we delete the instance profile * Cleanup imports * use ansible_dict_to_boto3_tag_list * Make sure retries are enabled * Update role names in line with CI policy * Lookup AMI name rather than hardcoding IDs * Add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…tions#326) * Mark ec2_launch_template tests as supported * Update launch template test to use permitted harmless managed policy * Make sure we delete the instance profile * Cleanup imports * use ansible_dict_to_boto3_tag_list * Make sure retries are enabled * Update role names in line with CI policy * Lookup AMI name rather than hardcoding IDs * Add changelog fragment
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…tions#326) * Mark ec2_launch_template tests as supported * Update launch template test to use permitted harmless managed policy * Make sure we delete the instance profile * Cleanup imports * use ansible_dict_to_boto3_tag_list * Make sure retries are enabled * Update role names in line with CI policy * Lookup AMI name rather than hardcoding IDs * Add changelog fragment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
disable shippable Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Enable Launch Template tests in CI
Todo:
ISSUE TYPE
COMPONENT NAME
ec2_launch_template
ADDITIONAL INFORMATION
See also: #322