secretsmanager_secret: add 'overwrite' parameter #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
tremble
force-pushed
the
feat/secretsmanager_secret-overwrite-param
branch
from
6ec6db2
to
ceba264
Compare
Adds an 'overwrite' parameter
- If set to True, an existing secret with the same name will be overwritten.
- If set to False, a secret with the given name will only be created if none exists.
Closes ansible-collections#1626
Signed-off-by: Brad Solomon <81818815+brsolomon-deloitte@users.noreply.github.com>
tremble
force-pushed
the
feat/secretsmanager_secret-overwrite-param
branch
from
2a92f21
to
414e554
Compare
tremble
force-pushed
the
feat/secretsmanager_secret-overwrite-param
branch
2 times, most recently
from
f9d729f
to
9eab93a
Compare
tremble
approved these changes
Feb 8, 2023
|
@brsolomon-deloitte Thanks for taking the time to submit this PR I've rebased the PR, added some integration tests and a changelog fragment. |
markuman
approved these changes
Feb 8, 2023
ansibullbot
added
integration
tremble
force-pushed
the
feat/secretsmanager_secret-overwrite-param
branch
from
9eab93a
to
ca18c50
Compare
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1715 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
secretsmanager_secret: add 'overwrite' parameter SUMMARY Adds an 'overwrite' parameter to secretsmanager_secret - If set to True, an existing secret with the same name will be overwritten. - If set to False, a secret with the given name will only be created if none exists. Fixes #1626 ISSUE TYPE Feature Pull Request COMPONENT NAME secretsmanager_secret ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit 4bfcb0c)
Thanks for rounding out the rest of the PR and getting it merged! This will be a valuable feature for us. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
[PR #1628/4bfcb0c8 backport][stable-5] secretsmanager_secret: add 'overwrite' parameter This is a backport of PR #1628 as merged into main (4bfcb0c). SUMMARY Adds an 'overwrite' parameter to secretsmanager_secret - If set to True, an existing secret with the same name will be overwritten. - If set to False, a secret with the given name will only be created if none exists. Fixes #1626 ISSUE TYPE Feature Pull Request COMPONENT NAME secretsmanager_secret ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an 'overwrite' parameter to secretsmanager_secret
Fixes #1626
ISSUE TYPE
COMPONENT NAME
secretsmanager_secret
ADDITIONAL INFORMATION