lambda_info - Return list of dicts as opposed to dict of dicts #1239

jatorcasso · 2022-06-14T21:02:32Z

SUMMARY

Previously returned function, which was a dict of dicts. Deprecated function in replace of lambda_info which is a list of dicts.
Return config details regardless of query (function_arn, function_name, etc)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

lambda_info

github-actions · 2022-06-14T21:06:28Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

ansibullbot · 2022-06-14T21:16:23Z

cc @jillr @markuman @pjodouin @s-hertel @steynovich @tremble
click here for bot help

softwarefactory-project-zuul · 2022-06-14T21:39:37Z

Build failed.

tremble · 2022-06-15T07:52:30Z

This seems a little excessive, I was expecting more:

"lambda_info": [
    {
        "aliases": [],
        "code_sha256": "mUwWuD7qBnKT2Q8cAGEyvbZelDUy+1Z7MOoIK6e9lIU=",
        "code_size": 854,
        "description": "",
        "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:7abd55cd699e",
        "function_name": "7abd55cd699e",
        "handler": "mini_lambda.handler",
        "last_modified": "2022-06-14T19:17:53.620+0000",
        "mappings": [],
        "memory_size": 128,
        "package_type": "Zip",
        "policy": {},
        "revision_id": "ba9a3e6e-7aa8-4568-ac78-0945db756a93",
        "role": "arn:aws:iam::721066863947:role/ansible-test-7abd55cd699e-lambda",
        "runtime": "python3.9",
        "state": "Pending",
        "state_reason": "The function is being created.",
        "state_reason_code": "Creating",
        "tags": {},
        "timeout": 3,
        "tracing_config": {
            "mode": "PassThrough"
        },
        "version": "$LATEST",
        "versions": [
            {
                "code_sha256": "mUwWuD7qBnKT2Q8cAGEyvbZelDUy+1Z7MOoIK6e9lIU=",
                "code_size": 854,
                "description": "",
                "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:7abd55cd699e:$LATEST",
                "function_name": "7abd55cd699e",
                "handler": "mini_lambda.handler",
                "last_modified": "2022-06-14T19:17:53.620+0000",
                "memory_size": 128,
                "package_type": "Zip",
                "revision_id": "ba9a3e6e-7aa8-4568-ac78-0945db756a93",
                "role": "arn:aws:iam::721066863947:role/ansible-test-7abd55cd699e-lambda",
                "runtime": "python3.9",
                "timeout": 3,
                "tracing_config": {
                    "mode": "PassThrough"
                },
                "version": "$LATEST"
            },
            {
                "code_sha256": "mUwWuD7qBnKT2Q8cAGEyvbZelDUy+1Z7MOoIK6e9lIU=",
                "code_size": 854,
                "description": "",
                "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:7abd55cd699e:$LATEST",
                "function_name": "7abd55cd699e",
                "handler": "mini_lambda.handler",
                "last_modified": "2022-06-14T19:17:53.620+0000",
                "memory_size": 128,
                "package_type": "Zip",
                "revision_id": "ba9a3e6e-7aa8-4568-ac78-0945db756a93",
                "role": "arn:aws:iam::721066863947:role/ansible-test-7abd55cd699e-lambda",
                "runtime": "python3.9",
                "timeout": 3,
                "tracing_config": {
                    "mode": "PassThrough"
                },
                "version": "$LATEST"
            },
            {
                "code_sha256": "mUwWuD7qBnKT2Q8cAGEyvbZelDUy+1Z7MOoIK6e9lIU=",
                "code_size": 854,
                "description": "",
                "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:7abd55cd699e:1",
                "function_name": "7abd55cd699e",
                "handler": "mini_lambda.handler",
                "last_modified": "2022-06-14T19:17:53.620+0000",
                "memory_size": 128,
                "package_type": "Zip",
                "revision_id": "e9df78b3-ccd1-4319-8c44-ef53b8a7bb8d",
                "role": "arn:aws:iam::721066863947:role/ansible-test-7abd55cd699e-lambda",
                "runtime": "python3.9",
                "timeout": 3,
                "tracing_config": {
                    "mode": "PassThrough"
                },
                "version": "1"
            }
        ]
    }
],
"response_metadata": {
    ...
}

jatorcasso · 2022-06-15T13:24:24Z

This seems a little excessive, I was expecting more:

I agree. However, response metadata is returned for each lambda, so i'm not sure how we could do that. Unless we returned a list of response_metadatas. that would look like this:

        "lambda_info": [
            {
                "aliases": [],
                "code_sha256": "moWCevrmdrdq0Q0hcJ/yRIwklHurs39Jx3UXETKtyRo=",
                "code_size": 854,
                "description": "",
                "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:ee709638beaa",
                "function_name": "ee709638beaa",
                "handler": "mini_lambda.handler",
                "last_modified": "2022-06-15T13:45:10.527+0000",
                "mappings": [],
                "memory_size": 128,
                "package_type": "Zip",
                "policy": {},
                "revision_id": "54a97a68-9d6f-468f-8cad-c8a99230c8b0",
                "role": "arn:aws:iam::721066863947:role/ansible-test-ee709638beaa-lambda",
                "runtime": "python3.9",
                "state": "Pending",
                "state_reason": "The function is being created.",
                "state_reason_code": "Creating",
                "tags": {},
                "timeout": 3,
                "tracing_config": {
                    "mode": "PassThrough"
                },
                "version": "$LATEST",
                "versions": [
                    {
                        "code_sha256": "moWCevrmdrdq0Q0hcJ/yRIwklHurs39Jx3UXETKtyRo=",
                        "code_size": 854,
                        "description": "",
                        "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:ee709638beaa:$LATEST",
                        "function_name": "ee709638beaa",
                        "handler": "mini_lambda.handler",
                        "last_modified": "2022-06-15T13:45:10.527+0000",
                        "memory_size": 128,
                        "package_type": "Zip",
                        "revision_id": "54a97a68-9d6f-468f-8cad-c8a99230c8b0",
                        "role": "arn:aws:iam::721066863947:role/ansible-test-ee709638beaa-lambda",
                        "runtime": "python3.9",
                        "timeout": 3,
                        "tracing_config": {
                            "mode": "PassThrough"
                        },
                        "version": "$LATEST"
                    },
                    {
                        "code_sha256": "moWCevrmdrdq0Q0hcJ/yRIwklHurs39Jx3UXETKtyRo=",
                        "code_size": 854,
                        "description": "",
                        "function_arn": "arn:aws:lambda:us-east-1:721066863947:function:ee709638beaa:1",
                        "function_name": "ee709638beaa",
                        "handler": "mini_lambda.handler",
                        "last_modified": "2022-06-15T13:45:10.527+0000",
                        "memory_size": 128,
                        "package_type": "Zip",
                        "revision_id": "df91a655-6d3e-4e5e-8caa-a522a57376ad",
                        "role": "arn:aws:iam::721066863947:role/ansible-test-ee709638beaa-lambda",
                        "runtime": "python3.9",
                        "timeout": 3,
                        "tracing_config": {
                            "mode": "PassThrough"
                        },
                        "version": "1"
                    }
                ]
            },
        ],
        "resource_actions": [
            "lambda:ListFunctions",
            "lambda:GetPolicy",
            "lambda:ListEventSourceMappings",
            "lambda:GetFunction",
            "lambda:GetFunctionConfiguration",
            "lambda:ListAliases",
            "lambda:ListVersionsByFunction"
        ],
        "response_metadata": [
            {
                "http_headers": {
                    "connection": "keep-alive",
                    "content-length": "986",
                    "content-type": "application/json",
                    "date": "Wed, 15 Jun 2022 13:45:12 GMT",
                    "x-amzn-requestid": "d20c6c3d-3219-4969-adbf-5c1f686f3082"
                },
                "http_status_code": 200,
                "request_id": "d20c6c3d-3219-4969-adbf-5c1f686f3082",
                "retry_attempts": 0
            },
        ]

softwarefactory-project-zuul · 2022-06-15T14:35:11Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-24T22:01:13Z

Build succeeded.

tremble · 2022-06-28T16:33:34Z

recheck

softwarefactory-project-zuul · 2022-06-28T16:52:51Z

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 03s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 30s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 22s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 20s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 27s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 9m 38s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

changelogs/fragments/1239-lambda_info-return_list.yml

softwarefactory-project-zuul · 2022-06-29T14:33:46Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-29T15:15:09Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-29T17:53:34Z

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 13s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 32s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 47s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 13s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-community.aws-1 SUCCESS in 8m 05s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

softwarefactory-project-zuul · 2022-06-29T17:53:37Z

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

softwarefactory-project-zuul · 2022-06-29T20:13:16Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-29T20:31:12Z

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 55s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 27s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 23s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 24s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 10s
✔️ ansible-test-splitter SUCCESS in 2m 58s
✔️ integration-community.aws-1 SUCCESS in 9m 21s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

patchback · 2022-06-29T20:31:19Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/32ade3bb6d226cbe62696093d1d85d7ebb60947a/pr-1239

Backported as #1287

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

lambda_info - Return list of dicts as opposed to dict of dicts SUMMARY Previously returned function, which was a dict of dicts. Deprecated function in replace of lambda_info which is a list of dicts. Return config details regardless of query (function_arn, function_name, etc) ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 32ade3b)

#1287) [PR #1239/32ade3bb backport][stable-4] lambda_info - Return list of dicts as opposed to dict of dicts This is a backport of PR #1239 as merged into main (32ade3b). SUMMARY Previously returned function, which was a dict of dicts. Deprecated function in replace of lambda_info which is a list of dicts. Return config details regardless of query (function_arn, function_name, etc) ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info Reviewed-by: Mark Chappell <None>

…le-collections#1239) lambda_info - Return list of dicts as opposed to dict of dicts SUMMARY Previously returned function, which was a dict of dicts. Deprecated function in replace of lambda_info which is a list of dicts. Return config details regardless of query (function_arn, function_name, etc) ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@32ade3b

…lections#1239) rds_instance_aurora/tests: increase the max job duration Reviewed-by: Mark Chappell <None>

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) python3 tests tests labels Jun 14, 2022

ansibullbot removed the needs_triage label Jun 15, 2022

jatorcasso force-pushed the lambda_info/return_list branch from 2f6a0a1 to 8110505 Compare June 24, 2022 21:44

jatorcasso requested review from tremble, jillr, alinabuzachis and markuman June 24, 2022 22:06

tremble requested changes Jun 29, 2022

View reviewed changes

changelogs/fragments/1239-lambda_info-return_list.yml Outdated Show resolved Hide resolved

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jun 29, 2022

jatorcasso requested a review from tremble June 29, 2022 14:16

alinabuzachis approved these changes Jun 29, 2022

View reviewed changes

jatorcasso added the backport-4 PR should be backported to the stable-4 branch label Jun 29, 2022

ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 29, 2022

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jun 29, 2022

tremble approved these changes Jun 29, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 29, 2022

ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 29, 2022

jatorcasso added 7 commits June 29, 2022 15:55

return list of dicts as opposed to dict of dicts

db7387e

changelog

20f9508

fix spacing in changelog

2c708d8

revert split of info into lambda and response_metadata

136fc3b

keep response metadata as is

08696bd

rename return val to functions

11c8402

apply code suggestions

5722e90

jatorcasso force-pushed the lambda_info/return_list branch from 20b1a5e to 5722e90 Compare June 29, 2022 19:55

softwarefactory-project-zuul bot merged commit 32ade3b into ansible-collections:main Jun 29, 2022

patchback bot mentioned this pull request Jun 29, 2022

[PR #1239/32ade3bb backport][stable-4] lambda_info - Return list of dicts as opposed to dict of dicts #1287

Merged

renovate bot mentioned this pull request Aug 8, 2022

chore(deps): update dependency community.aws to v4.1.1 linxside/ansible-ee#44

Merged

1 task

tremble mentioned this pull request Nov 18, 2022

lambda - Fix flaky integration tests which assume there are no other functions in the account ansible-collections/amazon.aws#1279

Merged

abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023

rds_instance_aurora/tests: increase the max job duration (ansible-col…

0910256

…lections#1239) rds_instance_aurora/tests: increase the max job duration Reviewed-by: Mark Chappell <None>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lambda_info - Return list of dicts as opposed to dict of dicts #1239

lambda_info - Return list of dicts as opposed to dict of dicts #1239

jatorcasso commented Jun 14, 2022 •

edited

Loading

github-actions bot commented Jun 14, 2022 •

edited

Loading

ansibullbot commented Jun 14, 2022

softwarefactory-project-zuul bot commented Jun 14, 2022

tremble commented Jun 15, 2022 •

edited

Loading

jatorcasso commented Jun 15, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 15, 2022

softwarefactory-project-zuul bot commented Jun 24, 2022

tremble commented Jun 28, 2022

softwarefactory-project-zuul bot commented Jun 28, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

patchback bot commented Jun 29, 2022 •

edited

Loading

lambda_info - Return list of dicts as opposed to dict of dicts #1239

lambda_info - Return list of dicts as opposed to dict of dicts #1239

Conversation

jatorcasso commented Jun 14, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

github-actions bot commented Jun 14, 2022 • edited Loading

Docs Build 📝

ansibullbot commented Jun 14, 2022

softwarefactory-project-zuul bot commented Jun 14, 2022

tremble commented Jun 15, 2022 • edited Loading

jatorcasso commented Jun 15, 2022 • edited Loading

softwarefactory-project-zuul bot commented Jun 15, 2022

softwarefactory-project-zuul bot commented Jun 24, 2022

tremble commented Jun 28, 2022

softwarefactory-project-zuul bot commented Jun 28, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

softwarefactory-project-zuul bot commented Jun 29, 2022

patchback bot commented Jun 29, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

jatorcasso commented Jun 14, 2022 •

edited

Loading

github-actions bot commented Jun 14, 2022 •

edited

Loading

tremble commented Jun 15, 2022 •

edited

Loading

jatorcasso commented Jun 15, 2022 •

edited

Loading

patchback bot commented Jun 29, 2022 •

edited

Loading