-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dms_endpoint - Support modifying tags #1234
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/purge/dms_endpoint
Jun 13, 2022
Merged
dms_endpoint - Support modifying tags #1234
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/purge/dms_endpoint
Jun 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
labels
Jun 9, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
force-pushed
the
tagging/purge/dms_endpoint
branch
from
June 10, 2022 13:03
457f110
to
30568a2
Compare
While it would be nice to add more detail to the various "settings" (both return and parameters), the sheer scope, when that's not the focus of this PR, means I'm leaving some of the return values as "dict". |
alinabuzachis
approved these changes
Jun 13, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
use ec2_ami to test ec2_snapshot_info
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_snapshot_info/tests: add unit-tests Depends-On: ansible-collections#1234 Depends-On: ansible-collections#1235 SUMMARY Add the unit-test coverage of the ec2_snapshot_info module. break up list_ec2_snapshots to move connection.describe_snapshots to separate method. COMPONENT NAME ec2_snapshot_info ADDITIONAL INFO latest CI run coverage report plugins_modules_ec2_snapshot_info_py.html Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
dms_endpoint
ADDITIONAL INFORMATION