Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dms_endpoint - Support modifying tags #1234

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 9, 2022

SUMMARY
  • Return details of the endpoint, even when not making changes
  • add purge_tags / resource_tags with the usual behaviour
  • Split tests
  • Add some very basic idempotency tests
  • support modifying tags
ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

dms_endpoint

ADDITIONAL INFORMATION
  • changelog

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 45s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 00s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 38s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 37s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 32s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 08s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 7m 53s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the tagging/purge/dms_endpoint branch from 457f110 to 30568a2 Compare June 10, 2022 13:03
@tremble
Copy link
Contributor Author

tremble commented Jun 10, 2022

While it would be nice to add more detail to the various "settings" (both return and parameters), the sheer scope, when that's not the focus of this PR, means I'm leaving some of the return values as "dict".

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 54s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 17s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 17s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 44s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 47s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-community.aws-1 SUCCESS in 8m 06s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 41s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 46s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 32s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 01s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 13s
✔️ ansible-test-splitter SUCCESS in 2m 53s
✔️ integration-community.aws-1 SUCCESS in 7m 43s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 49dff66 into ansible-collections:main Jun 13, 2022
@tremble tremble deleted the tagging/purge/dms_endpoint branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_snapshot_info/tests: add unit-tests

Depends-On: ansible-collections#1234
Depends-On: ansible-collections#1235
SUMMARY


Add the unit-test coverage of the ec2_snapshot_info module.
break up list_ec2_snapshots to move connection.describe_snapshots to  separate method.


COMPONENT NAME

ec2_snapshot_info
ADDITIONAL INFO
latest CI run coverage report  plugins_modules_ec2_snapshot_info_py.html

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants