Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wafv2_rule_group - support for managing tags #1210

Merged
merged 1 commit into from
Jun 7, 2022
Merged

wafv2_rule_group - support for managing tags #1210

merged 1 commit into from
Jun 7, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 3, 2022 •
edited
Loading

SUMMARY
  • Add support for returning tags
  • Add support for updating tags
  • Add support for purge_tags
  • Add fix for updating description when rules don't change.
  • Ensure description of rule group is returned when updates happen
  • Split integration tests from full wafv2 tests (full tests are broken)
ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

wafv2_rule_group
wafv2_rule_group_info

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-galaxy-importer FAILURE in 4m 10s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 09s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 12s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 18s
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 13m 47s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 11m 38s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 8m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 56s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 44s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 6m 22s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the tagging/purge/wafv2_rule_group branch 2 times, most recently from b34953e to 02065ed Compare June 3, 2022 19:31
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@tremble tremble force-pushed the tagging/purge/wafv2_rule_group branch from 02065ed to 738a7da Compare June 4, 2022 07:39
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 13s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 15s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 37s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 28s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 38s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 40s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 03s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 59s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 7m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested a review from jatorcasso June 7, 2022 19:56
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 55s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 50s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 51s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 15s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 47s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 57s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 6m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e9e37d1 into ansible-collections:main Jun 7, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the tagging/purge/wafv2_rule_group branch July 7, 2022 19:23
@tremble tremble mentioned this pull request Oct 6, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatorcasso jatorcasso jatorcasso approved these changes

@markuman markuman Awaiting requested review from markuman

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @jatorcasso