Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elb_instance - remove ec2_elbs fact #1173

Merged
merged 1 commit into from
May 30, 2022
Merged

elb_instance - remove ec2_elbs fact #1173

merged 1 commit into from
May 30, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 27, 2022

SUMMARY

The ec2_elbs fact was deprecated when we migrated to boto3, remove it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_instance

ADDITIONAL INFORMATION

See also: #773

@tremble tremble requested a review from markuman May 27, 2022 08:19
@ansibullbot
Copy link

cc @jarv @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels May 27, 2022
@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 04s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 49s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 43s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 53s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 13m 33s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 5m 08s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 10s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 36s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 08s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 13m 54s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 32s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 17s
✔️ ansible-test-splitter SUCCESS in 2m 55s
✔️ integration-community.aws-1 SUCCESS in 14m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 20a87c0 into ansible-collections:main May 30, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the deprecation/4.0.0/elb_instance branch July 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @alinabuzachis