lambda - fix check mode on creation #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
1 task
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
recheck |
jatorcasso
force-pushed
the
lambda/check-mode-fix
branch
from
54ebdd4
to
1cbbf46
Compare
alinabuzachis
approved these changes
May 3, 2022
| @@ -260,8 +260,10 @@ def main(): | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure if check_mode works correctly on lambda_execute, but I assume it's outside the scope of this PR.
|
The |
markuman
approved these changes
May 6, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1128 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2022
lambda - fix check mode on creation Depends-On: #1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes #1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit 0bde6bb)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 6, 2022
[PR #1108/0bde6bbd backport][stable-3] lambda - fix check mode on creation This is a backport of PR #1108 as merged into main (0bde6bb). Depends-On: #1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes #1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None>
1 task
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
lambda - fix check mode on creation Depends-On: ansible-collections#1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes ansible-collections#1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@0bde6bb
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Bump main to 6.0.0-dev0 SUMMARY Bump galaxy.yml version to 6.0.0-dev0 so we can start landing breaking changes ISSUE TYPE Feature Pull Request COMPONENT NAME galaxy.yml ADDITIONAL INFORMATION (still draft because I expect deprecation related CI failures) Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1116
SUMMARY
When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".
Added parameter
kms_key_arn- testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.Added extra waiter for function_update in
execute_lambdato resolve occasional integration test failure.Fixes #1111
ISSUE TYPE
COMPONENT NAME
lambda