s3_lifecycle: reassure that configuration is complete before returning. #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
lrubaszewski
force-pushed
the
s3_lifecycle_wait_until_ready
branch
from
840af4d
to
6d739e4
Compare
lrubaszewski
force-pushed
the
s3_lifecycle_wait_until_ready
branch
from
6d739e4
to
067533f
Compare
tremble
previously requested changes
Apr 20, 2022
...ogs/fragments/1085-s3_lifecycle-reassure-that-configuration-is-complete-before-returning.yml
Outdated
Show resolved
Hide resolved
|
Thanks for taking the time to submit this PR. One minor niggle on the formatting of the changelog entry |
Get bucket lifecycle configuration a few times to make sure it is stable. It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration returns alternatively new and old rules in a random manner. Similar issue reported for boto3 library: boto/boto3#2491
lrubaszewski
force-pushed
the
s3_lifecycle_wait_until_ready
branch
from
067533f
to
6206a49
Compare
|
@tremble I have applied changes according to the requests. |
marknet15
approved these changes
May 3, 2022
alinabuzachis
approved these changes
May 3, 2022
markuman
added
backport-2
jatorcasso
approved these changes
May 6, 2022
|
regate |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1131 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2022
…1085) s3_lifecycle: reassure that configuration is complete before returning. Get bucket lifecycle configuration a few times to make sure it is stable. It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration returns alternatively new and old rules in a random manner. Similar issue reported for boto3 library: boto/boto3#2491 SUMMARY Fixes #1084 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None> Reviewed-by: Lukasz Rubaszewski <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit d802749)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1132 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2022
…1085) s3_lifecycle: reassure that configuration is complete before returning. Get bucket lifecycle configuration a few times to make sure it is stable. It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration returns alternatively new and old rules in a random manner. Similar issue reported for boto3 library: boto/boto3#2491 SUMMARY Fixes #1084 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None> Reviewed-by: Lukasz Rubaszewski <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit d802749)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 9, 2022
…1085) (#1132) [PR #1085/d802749f backport][stable-3] s3_lifecycle: reassure that configuration is complete before returning. This is a backport of PR #1085 as merged into main (d802749). Get bucket lifecycle configuration a few times to make sure it is stable. It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration returns alternatively new and old rules in a random manner. Similar issue reported for boto3 library: boto/boto3#2491 SUMMARY Fixes #1084 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 9, 2022
…1085) (#1131) [PR #1085/d802749f backport][stable-2] s3_lifecycle: reassure that configuration is complete before returning. This is a backport of PR #1085 as merged into main (d802749). Get bucket lifecycle configuration a few times to make sure it is stable. It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration returns alternatively new and old rules in a random manner. Similar issue reported for boto3 library: boto/boto3#2491 SUMMARY Fixes #1084 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Alina Buzachis <None>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get bucket lifecycle configuration a few times to make sure it is stable.
It was observed that shortly (~30s) after setting the rules a method get-bucket-lifecycle-configuration
returns alternatively new and old rules in a random manner.
Similar issue reported for boto3 library:
boto/boto3#2491
SUMMARY
Fixes #1084
ISSUE TYPE
COMPONENT NAME
s3_lifecycle