-
Notifications
You must be signed in to change notification settings - Fork 396
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ecs_service -- with force_new_deployment user can specify taskdef or …
…not (#1680) (#1732) [PR #1680/6f844249 backport][stable-5] ecs_service -- with force_new_deployment user can specify taskdef or not This is a backport of PR #1680 as merged into main (6f84424). SUMMARY Fixes #1106 Support force_new_deployment without having to specify a task definition. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Previously task_definition was required when state was present; regardless of whether force_new_deployment was set or not. Previous error was along the lines of "state is present but all of the following are missing: task_definition". New behavior enforces either task_definition or force_new_deployment is set. If both are provided, the user's task_definition will be sent through to boto. If only task_definition is defined, original behavior resumes. If only force_new_deployment is set, pull the taskDefinition from existing and pass it through to boto. Reviewed-by: Mark Chappell
- Loading branch information
1 parent
6744af6
commit 5ab6594
Showing
3 changed files
with
37 additions
and
5 deletions.
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
changelogs/fragments/1680-ecs_service-force_redeploy_taskdef_optional.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- ecs_service - ``task_definition`` is now optional when ``force_new_deployment`` is ``True`` (https://github.com/ansible-collections/community.aws/pull/1680). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters