Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more no_log=False to fix sanity tests (fixes CI) #303

Merged
merged 1 commit into from
Mar 13, 2021
Merged

more no_log=False to fix sanity tests (fixes CI) #303

merged 1 commit into from
Mar 13, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

The no_log validate-modules test was improved, and now flags some more things. This adds no_log=False to two false-positives. This fixes the sanity tests for amazon.aws.

CC @tremble @jillr

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/ec2.py
plugins/modules/aws_s3.py

tremble
tremble approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge once tests pass.

  • max_keys: just a count
  • aws_access_key: the 'id' for an access key - no more secret than a username

@ansibullbot
Copy link

cc @lwade @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage plugins plugin (any type) small_patch Hopefully easy to review labels Mar 13, 2021
This was referenced Mar 13, 2021
Merged
Merged
markuman
markuman approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 3602af0 into ansible-collections:main Mar 13, 2021
@felixfontein
Copy link
Contributor Author

Tests finally passed 🎉

@tremble @markuman thanks a lot for reviewing this!

@felixfontein felixfontein deleted the secrets branch March 13, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module_utils module_utils module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @ansibullbot @tremble @markuman