Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1163/e3da3d50 backport][stable-5] expand module_utils.transformation unit tests #1164

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 12, 2022

This is a backport of PR #1163 as merged into main (e3da3d5).

SUMMARY

Expands the module_utils.transformation unit tests
ensure that map_complex_type still returns transformed items if items exists that are not in the type_map.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/transformation.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module_utils module_utils needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Oct 12, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

expand module_utils.transformation unit tests

SUMMARY
Expands the module_utils.transformation unit tests
ensure that map_complex_type still returns transformed items if items exists that are not in the type_map.
ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME
plugins/module_utils/transformation.py
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
(cherry picked from commit e3da3d5)
@tremble tremble force-pushed the patchback/backports/stable-5/e3da3d50deb755cc41bf628feeea28352b6ddc1b/pr-1163 branch from ba7fa78 to c7e47a7 Compare October 13, 2022 07:35
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 59s
✔️ build-ansible-collection SUCCESS in 4m 58s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 43s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 49s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 50s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 32s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 09s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 33s
✔️ cloud-tox-py3 SUCCESS in 3m 08s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-amazon.aws-1 SUCCESS in 7m 04s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 32s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 5m 33s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 36s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 25s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 20s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 23s
✔️ cloud-tox-py3 SUCCESS in 3m 12s
✔️ ansible-test-splitter SUCCESS in 2m 49s
✔️ integration-amazon.aws-1 SUCCESS in 5m 40s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 22d6dd8 into stable-5 Oct 13, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/e3da3d50deb755cc41bf628feeea28352b6ddc1b/pr-1163 branch October 13, 2022 08:23
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…sible-collections#1164)

ec2_metric_alarm - drop deprecated support for symbolic operators

SUMMARY
With the migration to boto3 symbolic operators were deprecated.  Remove it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_metric_alarm
ADDITIONAL INFORMATION
See also: ansible/ansible#62669

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…sible-collections#1164)

ec2_metric_alarm - drop deprecated support for symbolic operators

SUMMARY
With the migration to boto3 symbolic operators were deprecated.  Remove it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_metric_alarm
ADDITIONAL INFORMATION
See also: ansible/ansible#62669

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…sible-collections#1164)

ec2_metric_alarm - drop deprecated support for symbolic operators

SUMMARY
With the migration to boto3 symbolic operators were deprecated.  Remove it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_metric_alarm
ADDITIONAL INFORMATION
See also: ansible/ansible#62669

Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module_utils module_utils needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants