Add migration publishing, update config publishing and environmental variables #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codetheorist
changed the title
|
Looks good, but is there any reason for removing the |
|
@codetheorist you'll break anything prior to v5.3 for not much gain. Just environment support is probably enough for this PR rather then removing code that supports Laravel 4 onwards. |
bweston92
requested changes
Nov 12, 2017
| @@ -58,23 +58,20 @@ public function register() | |||
| */ | |||
| public function boot() | |||
| { | |||
| if (version_compare(Application::VERSION, '5.3', '>=')) { | |||
There was a problem hiding this comment.
@codetheorist add this back.
| @@ -9,15 +9,9 @@ class CreateSettingsTable extends Migration | |||
| { | |||
| public function __construct() | |||
| { | |||
| if (version_compare(Application::VERSION, '5.0', '>=')) { | |||
There was a problem hiding this comment.
@codetheorist add this back.
|
@codetheorist any update? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #81: Add migration publishing to service provider
Fixes Issues #65 & #83: Have config file pull values from environmental variables
env()helpers inconfig.phpto allow easier changing of important settings in a per-environment basis