Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: Upgrade cobra to v1.7.0 #608

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

dbirks
Copy link
Contributor

@dbirks dbirks commented Apr 27, 2023

This fixes an issue with cobra, more of an annoyance really for me, where you couldn't easily source the zsh completion script like you could with bash.

Here's the upstream PR with more info, that was released recently with v1.7.0: spf13/cobra#1917

Example of the completion not sourcing nicely before:

Screenshot from 2023-04-26 21-11-25

Completion after the cobra version bump:

Screenshot from 2023-04-26 21-09-55


Thanks a bunch for working on this CLI! I've only recently started using it, but have found it helpful.

Oh and that make install is quite handy. I didn't know you could go install from a local folder. Going to be using that a lot now. 🙂

To allow sourcing the zsh completion script.
spf13/cobra#1917
Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbirks 🎉

@ankitpokhrel ankitpokhrel merged commit d59cc82 into ankitpokhrel:main Apr 27, 2023
@dbirks dbirks deleted the bump-cobra branch April 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants