Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to make mypy work with Protobuf #3390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidculley
Copy link
Contributor

Add documentation for how to make mypy work with Protobuf without having to build the entire project or installing Rust.

@davidculley davidculley mentioned this pull request Aug 28, 2024
@dae
Copy link
Member

dae commented Aug 29, 2024

I'm afraid I don't want to encourage this David. You recently submitted a PR where Anki wouldn't even start, because you're not testing a full build. That's partly the fault of CI for not catching it, but it's also bad practice to be submitting changes without confirming a proper build locally. Merging this in will also mean another file that either needs to be updated as changes are made to the codebase, or confusion when it inevitably falls out of sync with the codebase and build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants