Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: enable option strict_optional for 'pylib' (#3317) #3355

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

mypy: enable option strict_optional for 'pylib' (#3317) #3355

wants to merge 8 commits into from

Commits on Aug 17, 2024

  1. refactor: explicitly add NoneType to type hints 

    If variable can be `None`, don't be implicit. Be explicit.
    @davidculley
    davidculley committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4a114af View commit details
    Browse the repository at this point in the history

  2. chore(mypy): invert option strict_optional 

    https://mypy.readthedocs.io/en/stable/config_file.html#inverting-option-values
    @davidculley
    davidculley committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a786b7a View commit details
    Browse the repository at this point in the history

  3. refactor: fix strict_optional for pylib 

    https://mypy.readthedocs.io/en/stable/config_file.html#confval-strict_optional
    @davidculley
    davidculley committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    48e6fd2 View commit details
    Browse the repository at this point in the history

  4. refactor: fix type hint of function argument 

    Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
    @davidculley @dae
    davidculley and dae committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    b69a116 View commit details
    Browse the repository at this point in the history

  5. refactor: fix type hint of function's return value 

    Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
    @davidculley @dae
    davidculley and dae committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    157a3d6 View commit details
    Browse the repository at this point in the history

  6. chore(mypy): disable strict_optional for _aqt 

    Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
    @davidculley @dae
    davidculley and dae committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    ff4bfcb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge remote-tracking branch 'upstream/main'

    @davidculley
    davidculley committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3e14268 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Fix startup error

    @dae
    dae committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9080aec View commit details
    Browse the repository at this point in the history