Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO API] Create Python entry points for creating and editing IO notes #2598

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

glutanimate
Copy link
Contributor

A first small batch of changes to create the API surface that the new version of IOE will need. More to follow as I continue with the rework – the bulk of the work will lie on the JS/Svelte side.

This batch targets the python editor API, slightly refactoring the current IO-related methods and creating entry-point methods for adding and editing image occlusions that abstract the Py → JS comms implementation details away.

CC @krmanik @dae

@dae
Copy link
Member

dae commented Jul 31, 2023

Looks good in isolation, but unfortunately has conflicted with Mani's recent changes. Mani's code assumes that the file picker function would be called on both add and edit paths, and your code is assuming it's only called for new notes, so will presumably need tweaking.

Also: Refactor IO-related methods, tweaking their naming and moving them to a continuous section
@glutanimate
Copy link
Contributor Author

OK, updated and rebased against main.

NB: Merging this PR would re-enable IO, so let's defer it until 2.1.66 is released, or if the release is likely to take longer and @krmanik and I need to work on IO things in parallel, let's merge it into an IO feature branch perhaps.

@dae
Copy link
Member

dae commented Aug 24, 2023

Release is out 🚀

@dae dae merged commit 5942671 into ankitects:main Aug 24, 2023
1 check passed
@dae
Copy link
Member

dae commented Aug 24, 2023

Your recent PRs are failing when merged - eg https://buildkite.com/ankitects/anki-ci/builds/6166#018a2565-c300-4559-a029-fa20a10581d5. Would you mind doing a quick PR that adds an edit to CONTRIBUTORS from GitHub's interface?

@glutanimate
Copy link
Contributor Author

Done! Looks like GH switched my account over to the new ID-based noreply format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants