Skip to content

Commit

Permalink
Update toast message in case of manual bug reporting
Browse files Browse the repository at this point in the history
  • Loading branch information
AayushSolanki authored and ShridharGoel committed Jan 31, 2022
1 parent 1f1ec7f commit f4ad4e1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void testProductionConfigurationUserAsk() throws Exception {
setAcraConfig("Production");
verifyACRANotDisabled();

assertToastMessage(R.string.feedback_manual_toast_text);
assertToastMessage(R.string.feedback_for_manual_toast_text);
assertToastIsEnabled();
assertDialogEnabledStatus("Dialog should be enabled", true);
}
Expand Down Expand Up @@ -211,7 +211,7 @@ public void testDialogEnabledWhenMovingFromAlwaysToAsk() throws Exception {
setAcraReportingMode(FEEDBACK_REPORT_ASK);

assertDialogEnabledStatus("dialog should be re-enabled after changed to ASK", true);
assertToastMessage(R.string.feedback_manual_toast_text);
assertToastMessage(R.string.feedback_for_manual_toast_text);
}

@Test
Expand All @@ -223,7 +223,7 @@ public void testToastTextWhenMovingFromAskToAlways() throws Exception {
setAcraConfig("Production");
verifyACRANotDisabled();

assertToastMessage(R.string.feedback_manual_toast_text);
assertToastMessage(R.string.feedback_for_manual_toast_text);

setAcraReportingMode(FEEDBACK_REPORT_ALWAYS);

Expand Down
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ public void setAcraReportingMode(String value) {
toastBuilder.setResText(R.string.feedback_auto_toast_text);
} else if (value.equals(FEEDBACK_REPORT_ASK)) {
dialogBuilder.setEnabled(true);
toastBuilder.setResText(R.string.feedback_manual_toast_text);
toastBuilder.setResText(R.string.feedback_for_manual_toast_text);
}
setAcraConfigBuilder(builder);
}
Expand Down
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/res/values/05-feedback.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<string name="feedback_title">AnkiDroid Feedback</string>
<string name="feedback_default_text">Enter your feedback or information about the nature of any errors you’re reporting.</string>
<string name="feedback_auto_toast_text">AnkiDroid has encountered a problem; a report is being sent to the developers…</string>
<string name="feedback_manual_toast_text">AnkiDroid has encountered a problem; a report is being generated…</string>
<string name="feedback_for_manual_toast_text">An error report is being prepared for the developers…</string>
<string name="feedback_copy_debug">Copy debug info</string>
<string name="feedback_report">Report</string>
<string name="feedback_report_automatically">Send error reports automatically</string>
Expand Down

0 comments on commit f4ad4e1

Please sign in to comment.