Fixed safety_assured for custom checks with safe_by_default - fixes #236

ankane · Aug 9, 2023 · ef8d306 · ef8d306
1 parent 4ea84af
commit ef8d306
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.6.1 (unreleased)
+
+- Fixed `safety_assured` for custom checks with `safe_by_default`
+
 ## 1.6.0 (2023-07-22)
 
 - Added check for `change_column_default`

diff --git a/lib/strong_migrations/checker.rb b/lib/strong_migrations/checker.rb
@@ -78,9 +78,11 @@ def perform(method, *args)
           @committed = true
         end
 
-        # custom checks
-        StrongMigrations.checks.each do |check|
-          @migration.instance_exec(method, args, &check)
+        if !safe?
+          # custom checks
+          StrongMigrations.checks.each do |check|
+            @migration.instance_exec(method, args, &check)
+          end
         end
       end