Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Profile/EditProfile #927

Closed
wants to merge 1 commit into from
Closed

Redesign: Profile/EditProfile #927

wants to merge 1 commit into from

Conversation

ravi5175
Copy link

Description

Closes #807

Redesigned Profile Section with a minimalistic UI approach
image

Changes:

Profile

  • added user profile picture support on the profile page
  • added profile cover photo support for the users
  • replaced switches that denotes whether a user is available for being mentor or need a mentor , to buttons that can be used to
    switch status instantly without getting into edit section.Status is being represented by changing colors (Green for active,Grey for inactive).

Edit Profile

  • click image to upload a new one

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

@sanchi0204
Copy link
Contributor

@ravi5175 pls add the ss under the docs/ui
and why gradle.bat files are committed?

@sanchi0204 sanchi0204 added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 18, 2020
@ravi5175
Copy link
Author

ravi5175 commented Sep 18, 2020

@sanchi0204 ss is already added in docs/ui
i added those gradle files from develop branch

if you want i will remove every other file from this branch except docs

@sanchi0204
Copy link
Contributor

@sanchi0204 ss is already added in docs/ui
i added those gradle files from develop branch

if you want i will remove every other file from this branch except docs

Yes pls remove those gradle files.

@ravi5175
Copy link
Author

@sanchi0204 please review it

@sanchi0204
Copy link
Contributor

@sanchi0204 please review it

This is fine but then it has files from your previous work as well which have been deleted.

Pls make a new branch without these files and only add files in docs/ui

I hope I am clear.

If not then pls discuss before making the changes

@ravi5175
Copy link
Author

@sanchi0204 please review it again

Copy link
Contributor

@sanchi0204 sanchi0204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sanchi0204 sanchi0204 added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Sep 18, 2020
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anna4j anna4j added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 21, 2020
@vj-codes
Copy link
Member

@ravi5175 thank you for your contribution 🎉
This PR will be closed and your contribution will be noted on OSH September 2020 Wiki Page

@vj-codes vj-codes closed this Nov 19, 2020
@vj-codes vj-codes added Category: User Interface Improvements or additions to design. Open Source Hack and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign: My Profile / Edit Profile screen
6 participants