Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Profile/Edit Profile View #926

Closed
wants to merge 4 commits into from
Closed

Redesign: Profile/Edit Profile View #926

wants to merge 4 commits into from

Conversation

ravi5175
Copy link

@ravi5175 ravi5175 commented Sep 18, 2020

Description

Closes #807

Redesigned Profile Section with a minimalistic UI approach
image

Changes:

Profile

  • added user profile picture support on the profile page
  • added profile cover photo support for the users
  • replaced switches that denotes whether a user is available for being mentor or need a mentor , to buttons that can be used to
    switch status instantly without getting into edit section.Status is being represented by changing colors (Green for active,Grey for inactive).

Edit Profile

  • click image to upload a new one

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

@ravi5175 ravi5175 closed this Sep 18, 2020
@ravi5175 ravi5175 reopened this Sep 18, 2020
@ravi5175 ravi5175 changed the title Redesigned Profile/Edit Profile View Redesign: Profile/Edit Profile View Sep 18, 2020
devkapilbansal
devkapilbansal previously approved these changes Sep 18, 2020
@sanchi0204
Copy link
Contributor

@ravi5175 It is mentioned in the issue that only UI mocks are required and changes in the code are not to be done.
I appreciate your efforts but please design the UI mock-ups in AdobeXD or Figma and add the link to the file under docs/ui folder as a .md file and the screenshot of the same under docs/ui folder.

Also, pls change the branch name from develop to something else; which is more relevant to the Issue.

@sanchi0204 sanchi0204 added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 18, 2020
@ravi5175
Copy link
Author

ravi5175 commented Sep 18, 2020

@sanchi0204 i am not able to locate this docs/ui in the repo, can you guide me

@ravi5175 ravi5175 closed this Sep 18, 2020
@vj-codes
Copy link
Member

@ravi5175 you have to create both docs and ui folders and then add the markdown file

@ravi5175
Copy link
Author

@sanchi0204 requested changes are done, please check it

@sanchi0204
Copy link
Contributor

@ravi5175 3 points to note:

  1. I am not able to access the link. Pls check on that.
  2. Add the screenshot as well under docs/ui
  3. change the branch name from develop to something else

Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravi5175 please squash your commits into one to keep the working directory clean

@ravi5175
Copy link
Author

@sanchi0204 , i had done the changes that you requested but i need to make a new pull request since this one still using the develop branch, so i am closing this one

@ravi5175 ravi5175 closed this Sep 18, 2020
@vj-codes vj-codes added Category: User Interface Improvements or additions to design. Open Source Hack and removed Status: Changes Requested Changes are required to be done by the PR author. labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign: My Profile / Edit Profile screen
5 participants