Skip to content

Commit

Permalink
Group imports in builder templates (open-telemetry#7020)
Browse files Browse the repository at this point in the history
goimport does not merge different blocks, it only splits blocks based on the rules. Because of that we should have only one import group and every repo splits by their rules.

See https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16828/files#diff-5040246c296b340124c7a2c8a7903ba51ae5fcf34a1d3e353cd2f49ab9bf07e3R14

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu committed Jan 25, 2023
1 parent 1af31a0 commit f8e42dd
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ package main

import (
"testing"

"github.com/stretchr/testify/assert"

"go.opentelemetry.io/collector/component/componenttest"
)

Expand Down
1 change: 0 additions & 1 deletion cmd/builder/internal/builder/templates/main.go.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package main

import (
"log"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/otelcol"
)
Expand Down
2 changes: 0 additions & 2 deletions cmd/builder/internal/builder/templates/main_windows.go.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ package main
import (
"fmt"
"os"

"golang.org/x/sys/windows/svc"

"go.opentelemetry.io/collector/otelcol"
)

Expand Down

0 comments on commit f8e42dd

Please sign in to comment.