Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all packages, fixed breaking changes, added nprogress for indicating route change… #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Khandakar227
Copy link

@Khandakar227 Khandakar227 commented Feb 5, 2022

References Issues

  1. No route changing indication when link clicked
  2. Old versions of Firebase, Next, react-hook-form
  3. Search bar onSubmit handler refreshes page. needs to prevent default behaviour.

What does this implement?

  1. Added a package named nprogress. Which shows a progress bar when link clicked
  2. Updated those packages. (Had 100+ security issues with older ones).
    Fixed breaking changes of those packages
  3. Fixed the search bar. Implemented it with FormData constructor. input useState not required

@vercel
Copy link

vercel bot commented Feb 5, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @anilsenay on Vercel.

@anilsenay first needs to authorize it.

@anilsenay
Copy link
Owner

@Khandakar227 Thank you for your contribution and congratz for your first pull request on Github 🎉

I will be review the changes in a week. Nowadays i am kinda busy sorry.

@Khandakar227
Copy link
Author

@anilsenay Thanks... No problem. Review when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants