Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(release): Version bump and changelog for release #4073

Merged
merged 2 commits into from
Feb 7, 2017

Conversation

heathkit
Copy link
Contributor

@heathkit heathkit commented Feb 7, 2017

No description provided.

package.json Outdated
@@ -15,7 +15,7 @@
"@types/node": "^6.0.46",
"@types/q": "^0.0.32",
"@types/selenium-webdriver": "~2.53.39",
"blocking-proxy": "0.0.5",
"blocking-proxy": "^0.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about allowing ^ since this is pre version 1 and versioning is nebulous -can we leave it precisely pinned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was hoping to be able to get out fixes without having to publish a new Protractor. But you're right, with things as they are it's probably better to just leave pinned.

@heathkit heathkit merged commit ba54422 into angular:master Feb 7, 2017
@wswebcreation
Copy link
Contributor

@mgiambalvo,

Maybe a stupid question, but protractor uses semver and the commits are features, shouldn't protractor be updated to 5.2.0 in stead of a fix release?

Tnx in advance

@heathkit
Copy link
Contributor Author

heathkit commented Feb 7, 2017

The main purpose of this release was to undo our accidental dependency on TS 2.1 (which was an unintentional breaking change) and fix support for TS 2.0. There were a couple tiny, low risk features that also made it in, so I left it at 5.1.1. Maybe you're right though, it could have easily been 5.2.0

@wswebcreation
Copy link
Contributor

Tnx for explaining, it's clear to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants