This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(error): throwing strings #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cnishina
commented
Aug 1, 2016
cnishina
commented
- fix throw string to throw new error
- check typeof error is string to create a new error
| } | ||
|
|
||
| if (typeof filenameOrFn === 'string') { | ||
| filenameOrFn = require(resolve(configDir, filenameOrFn)); | ||
| } | ||
| if (typeof filenameOrFn === 'function') { | ||
| let results = when(filenameOrFn.apply(null, args), null, (err) => { | ||
| if (err.stack) { | ||
| if (typeof err === 'string') { |
There was a problem hiding this comment.
what about
if (typeof err === 'string') {
err = new Error(err);
}
err.stack = exports.filterStackTrace(err.stack);
throw err;There was a problem hiding this comment.
Should we check if (!err.stack) instead of typeof? In case we get some crazy error object without a stack or something?
- fix throw string to throw new error - check typeof error is string to create a new error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.