feat(material/tooltip): replicate tooltipClass to default MatTooltipDefaultOptions #29467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipDefaultOptions The `tooltipClass` property has been added to the default configuration options in `MatTooltipDefaultOptions`. This new property is optional and supports the same syntax as `ngClass`, just like the component's default attribute. As with some existing configurations, if a CSS class is defined directly on the tooltip component, it will automatically override the default class. An example has been added to the `tooltip-demo` file. Additionally, two tests have been created to ensure the solution works as expected. Fixes angular#29355
jullierme
requested review from
crisbeto and
amysorto
and removed request for
a team
jullierme
changed the title
crisbeto
reviewed
Jul 21, 2024
…ipDefaultOptions The `tooltipClass` property has been added to the default configuration options in `MatTooltipDefaultOptions`. This new property is optional. As with some existing configurations, if a CSS class is defined directly on the tooltip component, it will automatically override the default class. Two tests have been created to ensure the solution works as expected. Fixes angular#29355
…ipDefaultOptions The `tooltipClass` property has been added to the default configuration options in `MatTooltipDefaultOptions`. This new property is optional. As with some existing configurations, if a CSS class is defined directly on the tooltip component, it will automatically override the default class. Two tests have been created to ensure the solution works as expected. Fixes angular#29355
|
@crisbeto the changes were made. Again, thanks a lot for reviewing it :) |
crisbeto
approved these changes
Jul 22, 2024
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tooltipClassproperty has been added to the default configuration options inMatTooltipDefaultOptions. This new property is optional and supports the same syntax asngClass, just like the component's default attribute. As with some existing configurations, if a CSS class is defined directly on the tooltip component, it will automatically override the default class. An example has been added to thetooltip-demofile. Additionally, two tests have been created to ensure the solution works as expected.Fixes #29355