Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Commit

Permalink
v1.7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
petebacondarwin committed Aug 8, 2018
1 parent cde950b commit 7fdb964
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 17 deletions.
9 changes: 6 additions & 3 deletions angular-aria.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @license AngularJS v1.7.2
* @license AngularJS v1.7.3
* (c) 2010-2018 Google, Inc. http://angularjs.org
* License: MIT
*/
Expand Down Expand Up @@ -63,7 +63,7 @@
var ARIA_DISABLE_ATTR = 'ngAriaDisable';

var ngAriaModule = angular.module('ngAria', ['ng']).
info({ angularVersion: '1.7.2' }).
info({ angularVersion: '1.7.3' }).
provider('$aria', $AriaProvider);

/**
Expand Down Expand Up @@ -392,7 +392,10 @@ ngAriaModule.directive('ngShow', ['$aria', function($aria) {
if ($aria.config('bindKeydown') && !attr.ngKeydown && !attr.ngKeypress && !attr.ngKeyup) {
elem.on('keydown', function(event) {
var keyCode = event.which || event.keyCode;
if (keyCode === 32 || keyCode === 13) {

if (keyCode === 13 || keyCode === 32) {
// Prevent the default browser behavior (e.g. scrolling when pressing spacebar).
event.preventDefault();

This comment has been minimized.

Copy link
@Head

Head Aug 27, 2018

@petebacondarwin When you have a parent element with ng-click and a child with for example an textarea, you cannot do space anymore in here. See: https://next.plnkr.co/edit/FYWckd17cmAe2iKz?preview

This comment has been minimized.

Copy link
@gkalpak
scope.$apply(callback);
}

Expand Down
18 changes: 9 additions & 9 deletions angular-aria.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7fdb964

Please sign in to comment.