Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade karma to version 4.4.0 #39180

Closed
wants to merge 1 commit into from

Conversation

bjarkler
Copy link
Contributor

@bjarkler bjarkler commented Oct 8, 2020

Upgrade the karma dependency to version 4.4.0 in the root package.json
and in integration tests. Compared to version 4.3.0, which most of the
packages were previously depending on, it has the following changes:

Bug Fixes

  • runner: remove explicit error on all tests failed

Features

  • client: Add trusted types support
  • Preprocessor can return Promise
  • config: add failOnSkippedTests option.
  • config: clientDisplayNone sets client elements display none.
  • deps: Remove core-js dependency.

The motivation for upgrading the package is the Trusted Types support
that it adds, which is necessary to enable Trusted Types in Angular's
unit tests.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: dev-infra

@bjarkler
Copy link
Contributor Author

bjarkler commented Oct 9, 2020

CC @engelsdamien @koto

@atscott atscott added the area: build & ci Related the build and CI infrastructure of the project label Oct 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 13, 2020
@mhevery mhevery added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Oct 19, 2020
@AndrewKushnir
Copy link
Contributor

@josephperrott would it make sense to update the required SHA here https://github.com/angular/angular/blob/master/.ng-dev/merge.ts#L24 as well once this PR lands?

@josephperrott
Copy link
Member

@AndrewKushnir Yeah, we can update it since it changes the runner.

@AndrewKushnir
Copy link
Contributor

Thanks @josephperrott, I'll take care of creating a new PR to update required base SHA once this PR lands.

Upgrade the karma dependency to version 4.4.0 in the root package.json
and in integration tests. Compared to version 4.3.0, which most of the
packages were previously depending on, it has the following changes:

Bug Fixes
- runner: remove explicit error on all tests failed

Features
- client: Add trusted types support
- Preprocessor can return Promise
- config: add failOnSkippedTests option.
- config: clientDisplayNone sets client elements display none.
- deps: Remove core-js dependency.

The motivation for upgrading the package is the Trusted Types support
that it adds, which is necessary to enable Trusted Types in Angular's
unit tests.
@AndrewKushnir
Copy link
Contributor

FYI, I've rebased this PR on top of the current version of the master branch, since the deploy_aio CircleCI job was failing, will see if it's resolved after rebase.

@josephperrott
Copy link
Member

@AndrewKushnir I will work on a fix now, but the failure for deploy_aio was caused by the job running without the expected PR contexts.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir I think the risk for regressions caused by non-rebased in-flight PRs is very low since we are not actually turning the trusted types support on in this PR, so I recommend waiting for the follow up PR that will turn TT support on in karma and only then updating the required rebase SHA.

@IgorMinar
Copy link
Contributor

quick note on the PR target: while we don’t need this in the RC branch, in order to minimize the diff between the master branch and the 10.0.x branch, it might be a good idea to retarget this as target: rc.

@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Oct 20, 2020
AndrewKushnir pushed a commit that referenced this pull request Oct 20, 2020
Upgrade the karma dependency to version 4.4.0 in the root package.json
and in integration tests. Compared to version 4.3.0, which most of the
packages were previously depending on, it has the following changes:

Bug Fixes
- runner: remove explicit error on all tests failed

Features
- client: Add trusted types support
- Preprocessor can return Promise
- config: add failOnSkippedTests option.
- config: clientDisplayNone sets client elements display none.
- deps: Remove core-js dependency.

The motivation for upgrading the package is the Trusted Types support
that it adds, which is necessary to enable Trusted Types in Angular's
unit tests.

PR Close #39180
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants