-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade karma to version 4.4.0 #39180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: dev-infra
@josephperrott would it make sense to update the required SHA here https://github.com/angular/angular/blob/master/.ng-dev/merge.ts#L24 as well once this PR lands? |
@AndrewKushnir Yeah, we can update it since it changes the runner. |
Thanks @josephperrott, I'll take care of creating a new PR to update required base SHA once this PR lands. |
Upgrade the karma dependency to version 4.4.0 in the root package.json and in integration tests. Compared to version 4.3.0, which most of the packages were previously depending on, it has the following changes: Bug Fixes - runner: remove explicit error on all tests failed Features - client: Add trusted types support - Preprocessor can return Promise - config: add failOnSkippedTests option. - config: clientDisplayNone sets client elements display none. - deps: Remove core-js dependency. The motivation for upgrading the package is the Trusted Types support that it adds, which is necessary to enable Trusted Types in Angular's unit tests.
a8c0972
to
0f1a18e
Compare
FYI, I've rebased this PR on top of the current version of the master branch, since the |
@AndrewKushnir I will work on a fix now, but the failure for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndrewKushnir I think the risk for regressions caused by non-rebased in-flight PRs is very low since we are not actually turning the trusted types support on in this PR, so I recommend waiting for the follow up PR that will turn TT support on in karma and only then updating the required rebase SHA.
quick note on the PR |
Upgrade the karma dependency to version 4.4.0 in the root package.json and in integration tests. Compared to version 4.3.0, which most of the packages were previously depending on, it has the following changes: Bug Fixes - runner: remove explicit error on all tests failed Features - client: Add trusted types support - Preprocessor can return Promise - config: add failOnSkippedTests option. - config: clientDisplayNone sets client elements display none. - deps: Remove core-js dependency. The motivation for upgrading the package is the Trusted Types support that it adds, which is necessary to enable Trusted Types in Angular's unit tests. PR Close #39180
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Upgrade the karma dependency to version 4.4.0 in the root package.json
and in integration tests. Compared to version 4.3.0, which most of the
packages were previously depending on, it has the following changes:
Bug Fixes
Features
The motivation for upgrading the package is the Trusted Types support
that it adds, which is necessary to enable Trusted Types in Angular's
unit tests.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?