This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(copy): clear array destinations correctly for non-array sources #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -803,6 +803,7 @@ function copy(source, destination, stackSource, stackDest) { | |||
| forEach(destination, function(value, key) { | |||
| delete destination[key]; | |||
| }); | |||
| if (isArray(destination)) destination.length = 0; | |||
There was a problem hiding this comment.
why don't you move the forEach above into an else branch here?
|
otherwise LGTM |
|
change made and merged, thanks for the prompt review! |
caitp
added a commit
that referenced
this pull request
Aug 21, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we failed to modify the
lengthproperty of an array destination whendealing with non-array sources. This CL ensures that the length is correctly reset
to 0 before copying properties from the source object.
While it's not a super-important feature, it's literally a single line of code and
not very difficult to understand
Closes #8610