fix($parse): do not use locals on field access #5862
Conversation
Do not use the locals when performing a field access Closes angular#5838
|
I'm impressed that this was an issue for so long with nobody noticing it! This change gets an r+ from me, but I think it will have to wait until the weekend or next week to be merged. Good work! (oh, sounds like it might get another review later today as well) Be sure to dog-food it before then just to make sure there isn't anything being missed by your test suite, but the fact that it's passing everything looks good =) LGTM |
| @@ -938,6 +940,13 @@ describe('parser', function() { | |||
| expect($parse('a.b')({a: {b: 0}}, {a: null})).toEqual(undefined); | |||
| expect($parse('a.b.c')({a: null}, {a: {b: {c: 1}}})).toEqual(1); | |||
| })); | |||
|
|
|||
| it('should use context resolution', inject(function($parse) { | |||
There was a problem hiding this comment.
it('should not use locals to resolve object fields',....
|
otherwise looks great. thanks @lgalfaso !!! |
|
Thanks a bunch, good work :) |
|
@lgalfaso it seems that we haven't sent you a t-shirt yet. we really value your contributions (this one and the others in the past). please fill out this form and we'll send you an AngularJS t-shirt: http://goo.gl/075Sj |
|
@IgorMinar Thanks |
Do not use the locals when performing a field access
Closes #5838