fix(ngResource): restore shallowClearAndCopy properties fitlering condition #5666
Conversation
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Oups my bad ! Should be ok now. |
ghost
assigned 
|
@thomasbelin4 can you make sure you signed the CLA with the email you are using on github ( Honestly I don't know why we strip out the |
|
Ok I signed the CLA with the right email address (sorry about that, that was my work git config) and also fixed the |
|
Just FYI, there's a typo in the first commit message: fitlering --> filtering |
|
It seems the travis build failed, but I don't really understand why.
Thank for your help |
|
@vojtajina ok, I tried a rebase in order to force the build and it passes now. Is there anything else I should do before my PR can be merged ? |
…dition Change the way properties are fitlered to create a resource from a JavaScript Object. in angular version >= 1.2.6 properties of a resource with a name beginning by a single '$' were fitlered from the created resource. Problem cames from the upgrade of the condition to filter properties that have a '$$' prefix in the shallow copy. See commit cb29632. Restore the behavior ngResource had in angular 1.2.5 and inferior versions.
in angular version >= 1.2.6 shallowCopy also filtered properties prefixed with a single `$` Problem cames from the upgrade of the condition to filter properties that have a '$$' prefix (See commit cb29632). Restore the behavior shallowCopy had in angular 1.2.5 and previous versions.
in angular version >= 1.2.6 shallowCopy also filtered properties
prefixed with a single `$`
Problem cames from the upgrade of the condition to
filter properties
that have a '$$' prefix (See commit cb29632).
add unit tests for the shallowCopy in AngularSpec
…ndition
Change the way properties are fitlered to create a resource
from a
JavaScript Object.
in angular version >= 1.2.6 properties of a
resource with a name
beginning by a single '$' were fitlered from
the created resource.
Problem cames from the upgrade of the
condition to filter properties that
have a '$$' prefix in the shallow
copy. See commit cb29632.
add the unit tests for shallowClearAndCopy function
… requests/responses ngResource no longer filters properties prefixed with a single "$" character from requests or responses, correcting a regression introduced in 1.2.6 (cb29632). Closes angular#5666 Closes angular#6080 Closes angular#6033
… requests/responses ngResource no longer filters properties prefixed with a single "$" character from requests or responses, correcting a regression introduced in 1.2.6 (cb29632). Closes angular#5666 Closes angular#6080 Closes angular#6033
Change the way properties are fitlered to create a resource from a
JavaScript Object.
in angular version >= 1.2.6 properties of a resource with a name
beginning by a single '$' were fitlered from the created resource.
Problem cames from the upgrade of the condition to filter properties that
have a '$$' prefix in the shallow copy. See commit cb29632.
Restore the behavior ngResource had in angular 1.2.5 and inferior
versions.