Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Added support for ngModel to be used seemless with isolate scope #3148

Closed
wants to merge 1 commit into from

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Jul 6, 2013

Fix for #1924

Added implementation + Updated documentation.

You no longer need to do

<my-component ng-model="$parent.my.model"></my-component>

And can instead write directives using isolate scope that behave as you would expect:

<my-component ng-model="my.model"></my-component>

Additional discussion: #1924 (comment)

…olate scope

Added implementation + Updated documentation
@pkozlowski-opensource
Copy link
Member

@IgorMinar @petebacondarwin I don't know how you feel about it but for me this it is more a work-around than a proper fix. It deals with the ngModel only but the problem mentioned in #1924 is more generic and present with other directives as well (eg. ngShow / ngHide).

@basarat This pull request is missing tests.

@basarat
Copy link
Contributor Author

basarat commented Jul 6, 2013

@pkozlowski-opensource I didn't realize the issue was with other directives as well (e.g. ngShow / ngHide). Further discussion in my comment: #1924 (comment) Feel free to close this request. I'll make an angular module that fixes ngModel for people that want to explicitly use it for now.

@pkozlowski-opensource
Copy link
Member

@basarat OK, going to close this one for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants