This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
chore: update Copyrights to Google LLC #17062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
force-pushed
the
fix-copyrights
branch
from
03da300
to
212e044
Compare
|
These are just changes to comments. The Saucelabs unit test failures on Windows appear to be flakes. |
gkalpak
suggested changes
Aug 13, 2020
There was a problem hiding this comment.
Thx, @Splaktar!
A couple of minor comments:
- I think we need to also update docs/app/src/examples.js.
- It is worth noting in the commit message that a similar change was done in build: bump year angular#27880.
Otherwise lgtm 👍
Splaktar
force-pushed
the
fix-copyrights
branch
from
212e044
to
717dd43
Compare
|
Review feedback addressed. Thank you. |
Splaktar
force-pushed
the
fix-copyrights
branch
from
717dd43
to
228e4e9
Compare
|
Rebased to give CI another chance to pass the unit tests... |
|
Thx, @Splaktar! Can you please replace |
- fix minor typo in comment Relates to angular/angular#27880
Splaktar
force-pushed
the
fix-copyrights
branch
from
228e4e9
to
f97d3da
Compare
|
Doh, sorry about that, done. |
|
CI has successfully run for this change as part of #17079. |
gkalpak
pushed a commit
that referenced
this pull request
Sep 30, 2020
- fix minor typo in comment Relates to angular/angular#27880 Closes #17062
AnkushLambdatest
pushed a commit
to AnkushLambdatest/angular.js
that referenced
this pull request
Jun 29, 2022
- fix minor typo in comment Relates to angular/angular#27880 Closes angular#17062
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.
Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
No
What is the current behavior?
The Copyrights currently use the old name, Google, Inc. You can see here that the new name is Google LLC and that Google, Inc. is the former name.
What is the new behavior?
Use Google LLC as the name. This is consistent with the angular/angular LICENSE.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: