Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Animations don't fire #4679

Closed
mgol opened this issue Oct 28, 2013 · 5 comments
Closed

Animations don't fire #4679

mgol opened this issue Oct 28, 2013 · 5 comments

Comments

@mgol
Copy link
Member

mgol commented Oct 28, 2013

Look at this simple jsFiddle: http://jsfiddle.net/5zJQx/; animations transitioning between states don't fire.

Now, it's possible that I've used it incorrectly but I looked at it a couple of times and it seemed OK (transitions are set on the *-add and *-remove classes) and ngAnimate documentation under: http://docs.angularjs.org/api/ngAnimate currently says very little about animations not involving entering/leaving elements...

@wesleycho
Copy link
Contributor

I actually came upon this last Friday - this will get it to work: http://jsfiddle.net/5zJQx/1/

I think something is up with the *-add and *-remove not being added in the right order - the point of them is to allow you to programmatically set the transitions & thus have a more controlled way of triggering the CSS animations, but this is currently not working the way it was intended.

This does not work properly in Chrome or Firefox that I've tested (newest for each), so I suspect it's a $animate problem.

@mik01aj
Copy link

mik01aj commented Oct 28, 2013

@wesleycho - your example doesn't use ngAnimate at all, just ordinary CSS transitions. Consider this simplified example: http://jsfiddle.net/nbPvW/1/ (note ngAnimate removed from dependencies).

@wesleycho
Copy link
Contributor

Ah, sorry, I didn't look closely enough - just assumed he was already using the animations since he had whipped up a fiddle. I came across the same problem myself though, but haven't attempted to reproduce it yet.

@matsko
Copy link
Contributor

matsko commented Oct 29, 2013

Landed as d434eab

@mgol
Copy link
Member Author

mgol commented Oct 29, 2013

@matsko Thanks :)

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants