Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Jsonp does not work in IE11. Angular 1.2 rc3 #4523

Closed
runxc1 opened this issue Oct 18, 2013 · 0 comments
Closed

Jsonp does not work in IE11. Angular 1.2 rc3 #4523

runxc1 opened this issue Oct 18, 2013 · 0 comments

Comments

@runxc1
Copy link

runxc1 commented Oct 18, 2013

Using IE11 that just shipped today I can see that angular is not calling the jsonp callback after the request succeeds.

For a simple example see here
http://plnkr.co/edit/sDKoQfUBDzwrSXTwA0cH?p=preview

The functionality worked correctly in IE10. The error is most likely not only found in RC3.

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Nov 22, 2013
IE8, IE9 and IE10 can use `script.onreadystate` so up till now we have been using this
if the sniffer says we are on IE.
But IE11 now does not support `script.onreadystate` and only supports the more standard
`script.onload` and `script.onerror`.
IE9 and IE10 do support `script.onload` and `script.onerror`. So now we only test whether
we are on IE8 or earlier before using `script.onreadystate`.
See http://pieisgood.org/test/script-link-events/

jQuery just uses all these handlers at once and hopes for the best, but since IE9 and IE10
support both sets of handlers, this could cause the handlers to be run more than once.

jQuery also notes that there is a potential memory leak in IE unless we remove the handlers
from the script object once they are run.  So we are doing this too, now.

Closes angular#4523
Closes angular#4527
Closes angular#4922
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…SONP

IE8, IE9 and IE10 can use `script.onreadystate` so up till now we have been using this
if the sniffer says we are on IE.
But IE11 now does not support `script.onreadystate` and only supports the more standard
`script.onload` and `script.onerror`.
IE9 and IE10 do support `script.onload` and `script.onerror`. So now we only test whether
we are on IE8 or earlier before using `script.onreadystate`.
See http://pieisgood.org/test/script-link-events/

jQuery just uses all these handlers at once and hopes for the best, but since IE9 and IE10
support both sets of handlers, this could cause the handlers to be run more than once.

jQuery also notes that there is a potential memory leak in IE unless we remove the handlers
from the script object once they are run.  So we are doing this too, now.

Closes angular#4523
Closes angular#4527
Closes angular#4922
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…SONP

IE8, IE9 and IE10 can use `script.onreadystate` so up till now we have been using this
if the sniffer says we are on IE.
But IE11 now does not support `script.onreadystate` and only supports the more standard
`script.onload` and `script.onerror`.
IE9 and IE10 do support `script.onload` and `script.onerror`. So now we only test whether
we are on IE8 or earlier before using `script.onreadystate`.
See http://pieisgood.org/test/script-link-events/

jQuery just uses all these handlers at once and hopes for the best, but since IE9 and IE10
support both sets of handlers, this could cause the handlers to be run more than once.

jQuery also notes that there is a potential memory leak in IE unless we remove the handlers
from the script object once they are run.  So we are doing this too, now.

Closes angular#4523
Closes angular#4527
Closes angular#4922
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant