Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngMobile's overridden ngClick directive fails to bust the click event #3132

Closed
davgothic opened this issue Jul 4, 2013 · 1 comment
Closed

ngMobile's overridden ngClick directive fails to bust the click event #3132

davgothic opened this issue Jul 4, 2013 · 1 comment

Comments

@davgothic
Copy link

If you tap a button that replaces itself with another element, the new element incorrectly receives a click event.

I believe the click event is supposed to be busted?

Here is an example of the problem: http://embed.plnkr.co/HQvrYQ/preview
@revolunet revolunet mentioned this issue Jul 5, 2013
Closed
@bshepherdson bshepherdson mentioned this issue Jul 24, 2013
Closed
bshepherdson pushed a commit to bshepherdson/angular.js that referenced this issue Jul 24, 2013
@revolunet @bshepherdson
fix(ngMobile): prevent ngClick when item disabled
a3955ae 
 - the ngClick attribute was always triggered, regardless the ngDisabled/disabled attributes
 - we now check the DOM disabled status before triggering the original click event
 - deals with angular#3124 angular#3132 /cc @shepheb
@davgothic davgothic mentioned this issue Jul 25, 2013
Closed
@davgothic
Copy link
Author

I believe this issue was incorrectly closed and under the advice of @shepheb I've create a new issue here: #3347

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davgothic