Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

anchor tag <a> doesn't work without href because of unsafe: link (IE 8 and below) #2219

Closed
dai-shi opened this issue Mar 25, 2013 · 0 comments
Closed

anchor tag <a> doesn't work without href because of unsafe: link (IE 8 and below) #2219

dai-shi opened this issue Mar 25, 2013 · 0 comments

Comments

@dai-shi
Copy link

dai-shi commented Mar 25, 2013

For IE8 and below, there is a special care in htmlAnchorDirective like the following:

if (msid <= 8) {
  if (!attr.href && !attr.name) {
    attr.$set('href', '');
  }
 ...

The change 9532234 is troublesome as it marks the href='' to be unsafe.

This used to work with angular-1.0.2.

Thanks.
@andershessellund andershessellund mentioned this issue May 6, 2013
Closed
petebacondarwin pushed a commit that referenced this issue Jul 3, 2013
@petebacondarwin
fix($compile): empty normalized href should pass sanitation check
3b2c6f0 
Sometimes IE returns an empty string for its normalized href on a tags.
This should pass the sanitation check in $compile.

Closes #2219, #2593
ctrahey pushed a commit to ctrahey/angular.js that referenced this issue Jul 22, 2013
@ctrahey
fix($compile): empty normalized href should pass sanitation check
f9f7513 
Sometimes IE returns an empty string for its normalized href on a tags.
This should pass the sanitation check in $compile.

Closes angular#2219, angular#2593
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($compile) empty href should pass sanitation check
1 participant
@dai-shi