Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

(WIP) chore(tests): use bower for test lib dependencies #1542

Closed
wants to merge 2 commits into from

Conversation

chrisirhc
Copy link
Contributor

Do not merge!

Update: I played around with switching version numbers and it looks like the version resolution on Bower is... incomplete. After switching the version number, one still has to go through some prompts in order to get the correct AngularJS version installed. I've opened an issue on bower/bower#1037.

Consider the npm install commit but for now I don't think we should use bower.


Also in this PR, run npm install on grunt configuration. I saw this on AngularJS and I think that's how they keep the packages Jenkins up-to-date. I'm thinking it's not that harmful but we can discuss if that shouldn't be in this PR.

Related to package discussion in #1503.

This keeps packages up to date as needed by the build process.
- Run bower install before every test run
@bekos
Copy link
Contributor

bekos commented Jan 8, 2014

Hmm, that's a problem. For now, I would suggest to use bower for our own convenience, and also check in the the installed components so that we don't confuse the rest of the contributors.

As a stepping stone, we can have a bower task (not wired to test or build), that just removes all bower components and installs the fresh ones.

@pkozlowski-opensource
Copy link
Member

I tend to agree with @bekos, I really like it when builds are super-fast. On the other hand we should make it as easy as possible for people to contribute... On top of this we really need to move to the SauceLab CI as currently the whole process of installing new dependencies on JenkinsCI is a bit painful.

@chrisirhc
Copy link
Contributor Author

@pkozlowski-opensource , what do you think about running npm install during grunt configuration (the first commit in this PR)? That should solve issues with CI.

@ghost ghost assigned bekos Jan 19, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Jan 21, 2014

@chrisirhc the problem with Travis CI is that the Angular guys (who are letting us use their travis server) want only certain dependencies to be installed on their server. Eg they almost definitely don't want any modules with native extensions that have to be compiled.

So there's a whitelist of dependencies that we have to update on the angular repo every time we want to change our build's dependencies. https://github.com/angular/ci.angularjs.org/blob/master/bin/angular-bootstrap-depcheck.js

This is why we want to move to travis and saucelabs, so we won't rely on them any longer. We are grateful that they have let us use it, but isn't best for us or the Angular team anymore.

@chrisirhc
Copy link
Contributor Author

Sounds good. I wrote that before realizing that was a whitelist of packages on the CI.

@chrisirhc
Copy link
Contributor Author

Closing in favor of #3461 .

@chrisirhc chrisirhc closed this Mar 28, 2015
@chrisirhc chrisirhc deleted the feature/rework-testing branch March 28, 2015 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants