Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Commit

Permalink
Update migration journey.
Browse files Browse the repository at this point in the history
Change-Id: I2ff9b1cd1bea6d16d83f5b082ac7071a5a7c7e31
  • Loading branch information
arriolac committed Jan 18, 2023
1 parent b7470b7 commit 5d42237
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,9 @@ fun SunflowerApp() {

// Helper function for calling a share functionality.
// Should be used when user presses a share button/menu item.
@Suppress("DEPRECATION")
private fun createShareIntent(activity: Activity, plantName: String) {
val shareText = activity.getString(R.string.share_text_plant, plantName)
val shareIntent = ShareCompat.IntentBuilder.from(activity)
val shareIntent = ShareCompat.IntentBuilder(activity)
.setText(shareText)
.setType("text/plain")
.createChooserIntent()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.livedata.observeAsState
import androidx.compose.ui.Modifier
<<<<<<< HEAD
import androidx.compose.ui.platform.testTag
=======
>>>>>>> f79850e (Migrate HomeViewPagerFragment to Compose.)
import androidx.compose.ui.res.dimensionResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.tooling.preview.PreviewParameter
Expand Down
4 changes: 3 additions & 1 deletion docs/MigrationJourney.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ The Sunflower app has 5 distinct screens. Each screen needs to be migrated to Co

## #3 Migrate Navigation Component to Compose and remove Fragments

Status: TODO
Status: Done ✅

PR: [#827](https://github.com/android/sunflower/pull/827)

The last step in the migration process is to replace Fragment-based navigation with Jetpack Navigation, to use [Navigation Compose](https://developer.android.com/jetpack/compose/navigation).
Upon completing this step, all Fragments can be removed.

0 comments on commit 5d42237

Please sign in to comment.